Chromium Code Reviews
Help | Chromium Project | Sign in
(96)

Issue 2751333004: [Crash Reporting] Only upload Chrome crash reports over unmetered networks.

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 2 days ago by Ilya Sherman
Modified:
5 days, 2 hours ago
CC:
chromium-reviews, sadrul, asvitkine+watch_chromium.org, agrieve+watch_chromium.org, kalyank, android-webview-reviews_chromium.org, gayane+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Crash Reporting] Only upload Chrome crash reports over unmetered networks. BUG=702454 TEST=none R=gsennton@chromium.org, mariakhomenko@chromium.org

Patch Set 1 #

Patch Set 2 : Update the JobScheduler constraints too! #

Total comments: 1

Patch Set 3 : git-add the new file #

Patch Set 4 : This is the last self-review patch set, I swear! :-P #

Total comments: 7

Patch Set 5 : Now with tests and everything! #

Patch Set 6 : --similarity=20, and revert a spurious diff #

Patch Set 7 : --similarity=10 #

Total comments: 1

Patch Set 8 : Remove stale BUILD file reference #

Patch Set 9 : Add TODO to use Junit4 parameters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -251 lines) Patch
M android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java View 1 2 3 4 3 chunks +5 lines, -9 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java View 1 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/android/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java View 1 2 3 4 2 chunks +2 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java View 1 2 3 4 5 6 7 8 3 chunks +6 lines, -14 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 3 4 5 6 7 8 2 chunks +1 line, -1 line 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManagerTest.java View 1 2 3 4 1 chunk +0 lines, -121 lines 0 comments Download
A + chrome/android/junit/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManagerTest.java View 1 2 3 4 5 6 7 8 1 chunk +79 lines, -89 lines 0 comments Download
M components/minidump_uploader/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadJobService.java View 1 1 chunk +1 line, -1 line 0 comments Download
A components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/NetworkPermissionUtil.java View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
Trybot results: Sign in to try more bots
Commit queue not available (can’t edit this change).

Messages

Total messages: 33 (24 generated)
Ilya Sherman
1 week, 2 days ago (2017-03-17 01:11:39 UTC) #1
Ilya Sherman
https://codereview.chromium.org/2751333004/diff/20001/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java File android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java (right): https://codereview.chromium.org/2751333004/diff/20001/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java#newcode60 android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java:60: return CrashReportingNetworkPermissionManager.isNetworkUnmetered( This class name is a bit unwieldy. ...
1 week, 2 days ago (2017-03-17 01:19:02 UTC) #9
Maria
https://codereview.chromium.org/2751333004/diff/60001/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingNetworkPermissionManager.java File components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingNetworkPermissionManager.java (right): https://codereview.chromium.org/2751333004/diff/60001/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingNetworkPermissionManager.java#newcode14 components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingNetworkPermissionManager.java:14: public class CrashReportingNetworkPermissionManager { given that there's nothing specific ...
1 week, 2 days ago (2017-03-17 04:04:29 UTC) #13
gsennton
lgtm (after changing the CrashReportingNetworkPermissionManager name to something shorter). https://codereview.chromium.org/2751333004/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java File chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java (left): https://codereview.chromium.org/2751333004/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java#oldcode78 chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java:78: ...
6 days, 7 hours ago (2017-03-20 17:29:01 UTC) #14
Ilya Sherman
https://codereview.chromium.org/2751333004/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java File chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java (left): https://codereview.chromium.org/2751333004/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java#oldcode78 chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java:78: NetworkInfo networkInfo = mConnectivityManager.getActiveNetworkInfo(); On 2017/03/20 17:29:01, gsennton wrote: ...
6 days, 1 hour ago (2017-03-20 23:11:21 UTC) #21
Maria
lgtm Yoland, a question for you. Can parameter sets be used in roboelectric unit tests ...
6 days, 1 hour ago (2017-03-20 23:23:40 UTC) #23
Maria
6 days, 1 hour ago (2017-03-20 23:24:12 UTC) #25
the real yoland
On 2017/03/20 at 23:23:40, mariakhomenko wrote: > lgtm > > Yoland, a question for you. ...
5 days, 23 hours ago (2017-03-21 00:35:02 UTC) #30
Ilya Sherman
5 days, 2 hours ago (2017-03-21 22:10:50 UTC) #33
I'm going to hold off on submitting this CL until the previous implementation is
merged to M58, so as to not cloud the data.

On 2017/03/21 00:35:02, the real yoland wrote:
> On 2017/03/20 at 23:23:40, mariakhomenko wrote:
> > lgtm
> > 
> > Yoland, a question for you. Can parameter sets be used in roboelectric unit
> tests today? I thought this test might be a good candidate.
> > 
> >
>
https://codereview.chromium.org/2751333004/diff/120001/chrome/android/junit/s...
> > File
>
chrome/android/junit/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManagerTest.java
> (right):
> > 
> >
>
https://codereview.chromium.org/2751333004/diff/120001/chrome/android/junit/s...
> >
>
chrome/android/junit/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManagerTest.java:52:
> runTest(CONNECTED, UNMETERED, METRICS_REPORTING_ENABLED,
> METRICS_UPLOAD_PERMITTED,
> > So I recently saw a presentation on junit4 and using ParameterSet to do
> exactly this (permutation of function calls into a helper). It was in the
> context of instrumentation, but I wonder if that works in roboelectric too. I
am
> going to add mailto:+yolandyan@chromium.org here and he should be able to tell
you the
> syntax if it's available. Makes these sorts of tests look nicer.
> 
> Yes, it can, it was designed to work with any Junit4 runners
> 
> The new parameter test framework can help in this case by changing this one
> monolithic into multiple test case and make sure they all run.
> 
> The parameter CL is still under review and I can help to convert this using
> parameter testing once it lands (https://codereview.chromium.org/2568633002).
> Feel free to add me as a TODO!
> 
> Thanks a lot for looping me in!

Thanks!  I've added a TODO for you in the latest patch set.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62