Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

Issue 2751333004: [Crash Reporting] Only upload Chrome crash reports over unmetered networks. (Closed)
Patch Set: This is the last self-review patch set, I swear! :-P Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
index 8bf871ae9981ea7933c1488111a26b29fde7411f..b8ce81c48c259bba8a86b2bbcf6bde4eb9ca2548 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
@@ -16,6 +16,7 @@ import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.device.DeviceClassManager;
import org.chromium.chrome.browser.physicalweb.PhysicalWeb;
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
+import org.chromium.components.minidump_uploader.util.CrashReportingNetworkPermissionManager;
import org.chromium.components.minidump_uploader.util.CrashReportingPermissionManager;
/**
@@ -191,24 +192,13 @@ public class PrivacyPreferencesManager implements CrashReportingPermissionManage
sharedPreferencesEditor.apply();
}
- private NetworkInfo getActiveNetworkInfo() {
+ protected boolean isNetworkAvailable() {
ConnectivityManager connectivityManager =
(ConnectivityManager) mContext.getSystemService(Context.CONNECTIVITY_SERVICE);
- return connectivityManager.getActiveNetworkInfo();
- }
-
- protected boolean isNetworkAvailable() {
- NetworkInfo networkInfo = getActiveNetworkInfo();
+ NetworkInfo networkInfo = connectivityManager.getActiveNetworkInfo();
return (networkInfo != null && networkInfo.isConnected());
}
- protected boolean isWiFiOrEthernetNetwork() {
- NetworkInfo networkInfo = getActiveNetworkInfo();
- return networkInfo != null
- && (networkInfo.getType() == ConnectivityManager.TYPE_WIFI
- || networkInfo.getType() == ConnectivityManager.TYPE_ETHERNET);
- }
-
protected boolean isMobileNetworkCapable() {
ConnectivityManager connectivityManager =
(ConnectivityManager) mContext.getSystemService(Context.CONNECTIVITY_SERVICE);
@@ -281,7 +271,9 @@ public class PrivacyPreferencesManager implements CrashReportingPermissionManage
*/
@Override
public boolean isNetworkAvailableForCrashUploads() {
- return isNetworkAvailable() && isWiFiOrEthernetNetwork();
+ ConnectivityManager connectivityManager =
+ (ConnectivityManager) mContext.getSystemService(Context.CONNECTIVITY_SERVICE);
+ return CrashReportingNetworkPermissionManager.isNetworkUnmetered(connectivityManager);
}
/**

Powered by Google App Engine
This is Rietveld 408576698