android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java - Issue 2751333004: [Crash Reporting] Only upload Chrome crash reports over unmetered networks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java

Issue 2751333004: [Crash Reporting] Only upload Chrome crash reports over unmetered networks. (Closed)

Patch Set: This is the last self-review patch set, I swear! :-P Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java

diff --git a/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java b/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java

index 22baa75ef1c0273e7b2a23c8ac48c226a83c9f76..a84bda3a1d43bc31afc03c027d1a4b0881796d6b 100644

--- a/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java

+++ b/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java

@@ -99,11 +99,8 @@ public class CrashReceiverService extends Service {

}

private void scheduleNewJob() {

- JobInfo.Builder builder =

- new JobInfo

- .Builder(TaskIds.WEBVIEW_MINIDUMP_UPLOADING_JOB_ID,

- new ComponentName(this, AwMinidumpUploadJobService.class))

- .setRequiredNetworkType(JobInfo.NETWORK_TYPE_UNMETERED);

+ JobInfo.Builder builder = new JobInfo.Builder(TaskIds.WEBVIEW_MINIDUMP_UPLOADING_JOB_ID,

+ new ComponentName(this, AwMinidumpUploadJobService.class));

MinidumpUploadJobService.scheduleUpload(this, builder);

}