Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3247)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

Issue 2751333004: [Crash Reporting] Only upload Chrome crash reports over unmetered networks. (Closed)
Patch Set: --similarity=10 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
index efbe2fbaa7a9047dfc5e7a1540b1b96f63b587b6..94688e792c57047ea3ff9db75b447fb5b94aa9c0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
@@ -17,6 +17,7 @@ import org.chromium.chrome.browser.device.DeviceClassManager;
import org.chromium.chrome.browser.physicalweb.PhysicalWeb;
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.components.minidump_uploader.util.CrashReportingPermissionManager;
+import org.chromium.components.minidump_uploader.util.NetworkPermissionUtil;
/**
* Reads, writes, and migrates preferences related to network usage and privacy.
@@ -184,24 +185,13 @@ public class PrivacyPreferencesManager implements CrashReportingPermissionManage
sharedPreferencesEditor.apply();
}
- private NetworkInfo getActiveNetworkInfo() {
+ protected boolean isNetworkAvailable() {
ConnectivityManager connectivityManager =
(ConnectivityManager) mContext.getSystemService(Context.CONNECTIVITY_SERVICE);
- return connectivityManager.getActiveNetworkInfo();
- }
-
- protected boolean isNetworkAvailable() {
- NetworkInfo networkInfo = getActiveNetworkInfo();
+ NetworkInfo networkInfo = connectivityManager.getActiveNetworkInfo();
return (networkInfo != null && networkInfo.isConnected());
}
- protected boolean isWiFiOrEthernetNetwork() {
- NetworkInfo networkInfo = getActiveNetworkInfo();
- return networkInfo != null
- && (networkInfo.getType() == ConnectivityManager.TYPE_WIFI
- || networkInfo.getType() == ConnectivityManager.TYPE_ETHERNET);
- }
-
protected boolean isMobileNetworkCapable() {
ConnectivityManager connectivityManager =
(ConnectivityManager) mContext.getSystemService(Context.CONNECTIVITY_SERVICE);
@@ -274,7 +264,9 @@ public class PrivacyPreferencesManager implements CrashReportingPermissionManage
*/
@Override
public boolean isNetworkAvailableForCrashUploads() {
- return isNetworkAvailable() && isWiFiOrEthernetNetwork();
+ ConnectivityManager connectivityManager =
+ (ConnectivityManager) mContext.getSystemService(Context.CONNECTIVITY_SERVICE);
+ return NetworkPermissionUtil.isNetworkUnmetered(connectivityManager);
}
/**

Powered by Google App Engine
This is Rietveld 408576698