Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

Issue 2751333004: [Crash Reporting] Only upload Chrome crash reports over unmetered networks. (Closed)
Patch Set: This is the last self-review patch set, I swear! :-P Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.crash; 5 package org.chromium.chrome.browser.crash;
6 6
7 import android.annotation.SuppressLint; 7 import android.annotation.SuppressLint;
8 import android.app.IntentService; 8 import android.app.IntentService;
9 import android.app.job.JobInfo; 9 import android.app.job.JobInfo;
10 import android.content.ComponentName; 10 import android.content.ComponentName;
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 permissions.putBoolean( 101 permissions.putBoolean(
102 ChromeMinidumpUploaderDelegate.IS_CRASH_UPLOAD_DISABLED_BY_COMMA ND_LINE, 102 ChromeMinidumpUploaderDelegate.IS_CRASH_UPLOAD_DISABLED_BY_COMMA ND_LINE,
103 permissionManager.isCrashUploadDisabledByCommandLine()); 103 permissionManager.isCrashUploadDisabledByCommandLine());
104 permissions.putBoolean(ChromeMinidumpUploaderDelegate.IS_UPLOAD_ENABLED_ FOR_TESTS, 104 permissions.putBoolean(ChromeMinidumpUploaderDelegate.IS_UPLOAD_ENABLED_ FOR_TESTS,
105 permissionManager.isUploadEnabledForTests()); 105 permissionManager.isUploadEnabledForTests());
106 106
107 JobInfo.Builder builder = 107 JobInfo.Builder builder =
108 new JobInfo 108 new JobInfo
109 .Builder(TaskIds.CHROME_MINIDUMP_UPLOADING_JOB_ID, 109 .Builder(TaskIds.CHROME_MINIDUMP_UPLOADING_JOB_ID,
110 new ComponentName(context, ChromeMinidumpUploadJ obService.class)) 110 new ComponentName(context, ChromeMinidumpUploadJ obService.class))
111 .setRequiredNetworkType(JobInfo.NETWORK_TYPE_ANY)
112 .setExtras(permissions); 111 .setExtras(permissions);
113 MinidumpUploadJobService.scheduleUpload(context, builder); 112 MinidumpUploadJobService.scheduleUpload(context, builder);
114 } 113 }
115 114
116 /** 115 /**
117 * Stores the successes and failures from uploading crash to UMA, 116 * Stores the successes and failures from uploading crash to UMA,
118 */ 117 */
119 public static void storeBreakpadUploadStatsInUma(ChromePreferenceManager pre f) { 118 public static void storeBreakpadUploadStatsInUma(ChromePreferenceManager pre f) {
120 for (String type : TYPES) { 119 for (String type : TYPES) {
121 for (int success = pref.getCrashSuccessUploadCount(type); success > 0; success--) { 120 for (int success = pref.getCrashSuccessUploadCount(type); success > 0; success--) {
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 return; 363 return;
365 } 364 }
366 365
367 if (shouldUseJobSchedulerForUploads()) { 366 if (shouldUseJobSchedulerForUploads()) {
368 scheduleUploadJob(context); 367 scheduleUploadJob(context);
369 } else { 368 } else {
370 tryUploadCrashDump(context, renamedMinidumpFile); 369 tryUploadCrashDump(context, renamedMinidumpFile);
371 } 370 }
372 } 371 }
373 } 372 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698