Converts ui::Accelerator::type to an enum

Converts ui::Accelerator::type to an enum

Accelerator::type_ was an EventType, but this is overkill as the type
can only be pressed or released. So, this converts the type to an enum
with those two values.

I'm doing this as I'm going to write a mojom for Accelerator and it's
better to restrict the mojom to the actual values.

BUG=701815
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2751323002
Cr-Commit-Position: refs/heads/master@{#457492}
Committed: https://chromium.googlesource.com/chromium/src/+/d56e56c7ea299f4b1f565f57022e9341265d3d28

[sky, 2017-03-16 03:51:58]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 03:52:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 06:24:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 06:24:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2017-03-16 16:57:22]

I like type re-use, but I guess this is okay. lgtm with a nit.

https://codereview.chromium.org/2751323002/diff/20001/ui/base/accelerators/ac...
File ui/base/accelerators/accelerator.h (right):

https://codereview.chromium.org/2751323002/diff/20001/ui/base/accelerators/ac...
ui/base/accelerators/accelerator.h:38: enum class KeyState {
very optional nit: If this weren't an enum class, users could cite values
without the extra typename scoping: ie.  ui::Accelerator::PRESSED vs
ui::Accelerator::KeyState::PRESSED, which would be a little less verbose.

[sky, 2017-03-16 17:06:40]

https://codereview.chromium.org/2751323002/diff/20001/ui/base/accelerators/ac...
File ui/base/accelerators/accelerator.h (right):

https://codereview.chromium.org/2751323002/diff/20001/ui/base/accelerators/ac...
ui/base/accelerators/accelerator.h:38: enum class KeyState {
On 2017/03/16 16:57:22, msw wrote:
> very optional nit: If this weren't an enum class, users could cite values
> without the extra typename scoping: ie.  ui::Accelerator::PRESSED vs
> ui::Accelerator::KeyState::PRESSED, which would be a little less verbose.

If I went down that route I would use a more verbose name for the enum values,
e.g. KEY_STATE_PRESSED, in which case it isn't really any shorter.

[sky, 2017-03-16 17:06:45]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-03-16 17:07:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 18:10:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489684005082760,
"parent_rev": "363735b939c7ce86349552cda7b012310f384fcb", "commit_rev":
"d56e56c7ea299f4b1f565f57022e9341265d3d28"}

[commit-bot: I haz the power, 2017-03-16 18:11:31]

Description was changed from

==========
Converts ui::Accelerator::type to an enum

Accelerator::type_ was an EventType, but this is overkill as the type
can only be pressed or released. So, this converts the type to an enum
with those two values.

I'm doing this as I'm going to write a mojom for Accelerator and it's
better to restrict the mojom to the actual values.

BUG=701815
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
Converts ui::Accelerator::type to an enum

Accelerator::type_ was an EventType, but this is overkill as the type
can only be pressed or released. So, this converts the type to an enum
with those two values.

I'm doing this as I'm going to write a mojom for Accelerator and it's
better to restrict the mojom to the actual values.

BUG=701815
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2751323002
Cr-Commit-Position: refs/heads/master@{#457492}
Committed:
https://chromium.googlesource.com/chromium/src/+/d56e56c7ea299f4b1f565f57022e...
==========

[commit-bot: I haz the power, 2017-03-16 18:11:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d56e56c7ea299f4b1f565f57022e...