Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: components/offline_pages/core/background/request_notifier.h

Issue 2751253004: [Offline Pages] Add UMA to record final offline request status and loading failed error code. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/request_notifier.h
diff --git a/components/offline_pages/core/background/request_notifier.h b/components/offline_pages/core/background/request_notifier.h
index 95fbb09f3cda876a1b209149efdc09e27c6991c6..e5723a8ef44e0a8d2efa429711b52c8a99a907d2 100644
--- a/components/offline_pages/core/background/request_notifier.h
+++ b/components/offline_pages/core/background/request_notifier.h
@@ -15,16 +15,20 @@ class RequestNotifier {
// NOTE: for any changes to the enum, please also update related switch code
// in RequestCoordinatorEventLogger.
// GENERATED_JAVA_ENUM_PACKAGE:org.chromium.components.offlinepages
+ // WARNING: You must update histograms.xml to match any changes made to
+ // this enum (ie, histogram enum for OfflinePagesBackgroundSavePageResult).
enum class BackgroundSavePageResult {
- SUCCESS,
- LOADING_FAILURE,
- LOADING_CANCELED,
- FOREGROUND_CANCELED,
- SAVE_FAILED,
- EXPIRED,
- RETRY_COUNT_EXCEEDED,
- START_COUNT_EXCEEDED,
- REMOVED,
+ SUCCESS = 0,
+ LOADING_FAILURE = 1,
+ LOADING_CANCELED = 2,
+ FOREGROUND_CANCELED = 3,
+ SAVE_FAILED = 4,
+ EXPIRED = 5,
+ RETRY_COUNT_EXCEEDED = 6,
+ START_COUNT_EXCEEDED = 7,
+ REMOVED = 8,
+ // NOTE: insert new values above this line and update histogram enum too.
+ STATUS_COUNT
};
virtual ~RequestNotifier() = default;

Powered by Google App Engine
This is Rietveld 408576698