components/offline_pages/core/background/request_coordinator_unittest.cc - Issue 2751253004: [Offline Pages] Add UMA to record final offline request status and loading failed error code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/core/background/request_coordinator_unittest.cc

Issue 2751253004: [Offline Pages] Add UMA to record final offline request status and loading failed error code. (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/core/background/request_coordinator.cc ('k') | components/offline_pages/core/background/request_notifier.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/core/background/request_coordinator_unittest.cc

diff --git a/components/offline_pages/core/background/request_coordinator_unittest.cc b/components/offline_pages/core/background/request_coordinator_unittest.cc

index 0c5030cb5ba73773293469ccff6193d02613a3c2..0fb6df222005f9c6708b912ec6e049569516f32e 100644

--- a/components/offline_pages/core/background/request_coordinator_unittest.cc

+++ b/components/offline_pages/core/background/request_coordinator_unittest.cc

@@ -670,6 +670,9 @@ TEST_F(RequestCoordinatorTest, OfflinerDoneRequestSucceeded) {

// Check that the observer got the notification that we succeeded, and that

// the request got removed from the queue.

EXPECT_TRUE(observer().completed_called());

+ histograms().ExpectBucketCount(

+ "OfflinePages.Background.FinalSavePageResult.bookmark", 0, /* SUCCESS */

Pete Williamson 2017/03/17 20:50:56 Are there any tests where we could check for a fai

chili 2017/03/17 21:17:18 Done.

+ 1);

EXPECT_EQ(RequestCoordinator::BackgroundSavePageResult::SUCCESS,

observer().last_status());

}