chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc - Issue 2751253004: [Offline Pages] Add UMA to record final offline request status and loading failed error code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

Issue 2751253004: [Offline Pages] Add UMA to record final offline request status and loading failed error code. (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/background_loader_offliner.cc ('k') | components/offline_pages/core/background/request_coordinator.cc » ('j') | components/offline_pages/core/background/request_coordinator_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

diff --git a/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc b/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

index 88aee2ce05e9ea2c1309479182fd4e93f050192b..f3c0e292120ab0b3f2291e8833c99f6069f1be78 100644

--- a/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

+++ b/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

@@ -33,7 +33,7 @@ namespace {

const int64_t kRequestId = 7;

const GURL kHttpUrl("http://www.tunafish.com");

const GURL kFileUrl("file://salmon.png");

-const ClientId kClientId("AsyncLoading", "88");

+const ClientId kClientId("async_loading", "88");

const bool kUserRequested = true;

// Mock OfflinePageModel for testing the SavePage calls

@@ -432,6 +432,10 @@ TEST_F(BackgroundLoaderOfflinerTest, FailsOnErrorPage) {

offliner()->DidFinishNavigation(handle.get());

// NavigationHandle is always destroyed after finishing navigation.

handle.reset();

+ histograms().ExpectBucketCount(

+ "OfflinePages.Background.BackgroundLoadingFailedCode.async_loading",

+ 105, // ERR_NAME_NOT_RESOLVED

+ 1);

offliner()->DidStopLoading();

PumpLoop();