[MD settings] align minimum font size on example

[MD settings] align minimum font size on example

This CL removes a <span> so that the font size number is aligned with
the font example text.

BUG=702093
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2751253003
Cr-Commit-Position: refs/heads/master@{#457879}
Committed: https://chromium.googlesource.com/chromium/src/+/5bb896d38e5404ae87b613e7f55e876e594d78ad

[dschuyler, 2017-03-16 19:14:39]

Description was changed from

==========
[MD settings] align minimum font size on example

This CL removes a <span> so that the font size number is aligned with
the font example text.

BUG=702093
==========

to

==========
[MD settings] align minimum font size on example

This CL removes a <span> so that the font size number is aligned with
the font example text.

BUG=702093
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-03-16 19:14:42]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 19:15:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-03-16 19:15:40]

dschuyler@chromium.org changed reviewers:
+ scottchen@chromium.org

[scottchen, 2017-03-16 19:58:16]

On 2017/03/16 19:15:40, dschuyler wrote:

could I see a before/after screenshot?

[dschuyler, 2017-03-16 20:44:58]

On 2017/03/16 19:58:16, scottchen wrote:
> On 2017/03/16 19:15:40, dschuyler wrote:
> 
> could I see a before/after screenshot?

I've added a screen shot in comment #5 of the bug.

[scottchen, 2017-03-16 21:27:08]

On 2017/03/16 20:44:58, dschuyler wrote:
> On 2017/03/16 19:58:16, scottchen wrote:
> > On 2017/03/16 19:15:40, dschuyler wrote:
> > 
> > could I see a before/after screenshot?
> 
> I've added a screen shot in comment #5 of the bug.

lgtm

[dschuyler, 2017-03-16 21:32:44]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 21:33:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-03-16 21:35:25]

On 2017/03/16 21:27:08, scottchen wrote:
> On 2017/03/16 20:44:58, dschuyler wrote:
> > On 2017/03/16 19:58:16, scottchen wrote:
> > > On 2017/03/16 19:15:40, dschuyler wrote:
> > > 
> > > could I see a before/after screenshot?
> > 
> > I've added a screen shot in comment #5 of the bug.
> 
> lgtm

Thanks for asking about the list-item class. It was not needed anymore. I've
removed it in path #2. PTAL.

[scottchen, 2017-03-16 21:45:24]

On 2017/03/16 21:35:25, dschuyler wrote:
> On 2017/03/16 21:27:08, scottchen wrote:
> > On 2017/03/16 20:44:58, dschuyler wrote:
> > > On 2017/03/16 19:58:16, scottchen wrote:
> > > > On 2017/03/16 19:15:40, dschuyler wrote:
> > > > 
> > > > could I see a before/after screenshot?
> > > 
> > > I've added a screen shot in comment #5 of the bug.
> > 
> > lgtm
> 
> Thanks for asking about the list-item class. It was not needed anymore. I've
> removed it in path #2. PTAL.

still lgtm

[commit-bot: I haz the power, 2017-03-16 23:55:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 23:55:09]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-03-17 04:04:17]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-03-17 04:04:17]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-03-17 04:04:17]

lgtm

[commit-bot: I haz the power, 2017-03-17 04:04:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 04:08:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 04:08:28]

Failed to apply patch for
chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html:
While running git apply --index -p1;
  error: patch failed:
chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html:21
  error:
chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html:
patch does not apply

Patch:      
chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html
Index:
chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html
diff --git
a/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html
b/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html
index
fe1e45a2b06757bba2d6b2aa24e0bab44a86fe96..35705e32060e6a1bf11bca598fff8489c4d08006
100644
---
a/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html
+++
b/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html
@@ -21,16 +21,14 @@
     </div>
     <div class="settings-box">
       <div class="start">$i18n{minimumFont}</div>
-      <div class="list-item"
-          style="
-              font-size:[[computeMinimumFontSize_(
-                  prefs.webkit.webprefs.minimum_font_size.value)]]px;
-              font-family:
-                  '[[prefs.webkit.webprefs.fonts.standard.Zyyy.value]]';">
-        <span>[[
-            computeMinimumFontSize_(
-                prefs.webkit.webprefs.minimum_font_size.value)]]</span>
-        : $i18n{quickBrownFox}
+      <div style="
+          font-size:[[computeMinimumFontSize_(
+              prefs.webkit.webprefs.minimum_font_size.value)]]px;
+          font-family:
+              '[[prefs.webkit.webprefs.fonts.standard.Zyyy.value]]';">
+        [[computeMinimumFontSize_(
+                prefs.webkit.webprefs.minimum_font_size.value)]]:
+        $i18n{quickBrownFox}
       </div>
       <cr-slider id="minimumSizeSlider"
           pref="{{prefs.webkit.webprefs.minimum_font_size}}"

[dschuyler, 2017-03-17 18:35:43]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 18:36:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 19:46:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 19:46:02]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-03-17 20:40:17]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2017-03-17 20:40:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
scottchen@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2751253003/#ps40001
(title: "merge master")

[commit-bot: I haz the power, 2017-03-17 20:40:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 20:46:42]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489783217441870,
"parent_rev": "fdca656fa2bb10c52d6ccb13a667d55c32f72b80", "commit_rev":
"5bb896d38e5404ae87b613e7f55e876e594d78ad"}

[commit-bot: I haz the power, 2017-03-17 20:47:26]

Description was changed from

==========
[MD settings] align minimum font size on example

This CL removes a <span> so that the font size number is aligned with
the font example text.

BUG=702093
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] align minimum font size on example

This CL removes a <span> so that the font size number is aligned with
the font example text.

BUG=702093
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2751253003
Cr-Commit-Position: refs/heads/master@{#457879}
Committed:
https://chromium.googlesource.com/chromium/src/+/5bb896d38e5404ae87b613e7f55e...
==========

[commit-bot: I haz the power, 2017-03-17 20:47:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5bb896d38e5404ae87b613e7f55e...