Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 2751233002: Revert of xdg-settings: add secondary check in GetIsDefaultWebClient (Closed)

Created:
3 years, 9 months ago by Tom (Use chromium acct)
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of xdg-settings: add secondary check in GetIsDefaultWebClient (patchset #2 id:40001 of https://codereview.chromium.org/2737283002/ ) Reason for revert: mdm@ says this is the wrong approach Original issue's description: > xdg-settings: add secondary check in GetIsDefaultWebClient > > This CL fixes an issue where Chrome would display a banner saying that it > was not the default browser when it actually was. > > The cause of this was 'xdg-settings check default-web-browser > google-chrome.desktop' returning 'no' when Chrome might have been the > default (see further explanation in the CL comments). > > BUG=578888 > R=thestig@chromium.org > > Review-Url: https://codereview.chromium.org/2737283002 > Cr-Commit-Position: refs/heads/master@{#456224} > Committed: https://chromium.googlesource.com/chromium/src/+/dece487a37276f1043d8092acd01a761ec99c17e TBR=thestig@chromium.org,mdm@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=578888 Review-Url: https://codereview.chromium.org/2751233002 Cr-Commit-Position: refs/heads/master@{#457272} Committed: https://chromium.googlesource.com/chromium/src/+/8258b1c5ed8ce2a96dfdba9ce36263a2de2ba768

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -55 lines) Patch
M chrome/browser/shell_integration_linux.cc View 4 chunks +24 lines, -55 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Tom (Use chromium acct)
Created Revert of xdg-settings: add secondary check in GetIsDefaultWebClient
3 years, 9 months ago (2017-03-15 22:54:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751233002/1
3 years, 9 months ago (2017-03-15 22:54:54 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 9 months ago (2017-03-15 22:54:56 UTC) #5
Lei Zhang
lgtm GetIsDefaultWebClient() returns...
3 years, 9 months ago (2017-03-15 23:11:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751233002/1
3 years, 9 months ago (2017-03-15 23:12:50 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 00:06:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8258b1c5ed8ce2a96dfdba9ce362...

Powered by Google App Engine
This is Rietveld 408576698