Skip ruleset invalidations for SubtreeStyleChange roots.

Skip ruleset invalidations for SubtreeStyleChange roots.

When the TreeScope invalidation root is already with SubtreeStyleChange
there is no need to schedule ruleset invalidations for that scope. We
did not end up scheduling the invalidation sets, but went through a lot
of unnecessary steps in scheduleInvalidationsForRuleSets(). Instead,
just return early.

Added some more tests and corrected typos from
https://crrev.com/5fef4a38

Review-Url: https://codereview.chromium.org/2751193004
Cr-Commit-Position: refs/heads/master@{#457715}
Committed: https://chromium.googlesource.com/chromium/src/+/2b9e4d03756be0ca4867bc1a03f8bd69f3eed43b

[rune, 2017-03-16 14:12:11]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 14:12:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 15:39:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 15:39:01]

Dry run: This issue passed the CQ dry run.

[rune, 2017-03-16 22:57:28]

rune@opera.com changed reviewers:
+ nainar@chromium.org

[rune, 2017-03-16 22:57:28]

ptal

[nainar, 2017-03-17 01:43:42]

lgtm. 

On a side note thank you for sending this patch to me - got to look at how to
write a unit test for the Style Engine. A weakness of mine. :)

[rune, 2017-03-17 08:21:06]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2017-03-17 08:21:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 08:26:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489738866771370, "parent_rev":
"2fd6cd8bbc2fdd7aaab8d7536692e62bced41c15", "commit_rev":
"2b9e4d03756be0ca4867bc1a03f8bd69f3eed43b"}

[commit-bot: I haz the power, 2017-03-17 08:26:53]

Description was changed from

==========
Skip ruleset invalidations for SubtreeStyleChange roots.

When the TreeScope invalidation root is already with SubtreeStyleChange
there is no need to schedule ruleset invalidations for that scope. We
did not end up scheduling the invalidation sets, but went through a lot
of unnecessary steps in scheduleInvalidationsForRuleSets(). Instead,
just return early.

Added some more tests and corrected typos from
https://crrev.com/5fef4a38
==========

to

==========
Skip ruleset invalidations for SubtreeStyleChange roots.

When the TreeScope invalidation root is already with SubtreeStyleChange
there is no need to schedule ruleset invalidations for that scope. We
did not end up scheduling the invalidation sets, but went through a lot
of unnecessary steps in scheduleInvalidationsForRuleSets(). Instead,
just return early.

Added some more tests and corrected typos from
https://crrev.com/5fef4a38

Review-Url: https://codereview.chromium.org/2751193004
Cr-Commit-Position: refs/heads/master@{#457715}
Committed:
https://chromium.googlesource.com/chromium/src/+/2b9e4d03756be0ca4867bc1a03f8...
==========

[commit-bot: I haz the power, 2017-03-17 08:26:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b9e4d03756be0ca4867bc1a03f8...