Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2751193004: Skip ruleset invalidations for SubtreeStyleChange roots. (Closed)

Created:
3 years, 9 months ago by rune
Modified:
3 years, 9 months ago
Reviewers:
nainar
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip ruleset invalidations for SubtreeStyleChange roots. When the TreeScope invalidation root is already with SubtreeStyleChange there is no need to schedule ruleset invalidations for that scope. We did not end up scheduling the invalidation sets, but went through a lot of unnecessary steps in scheduleInvalidationsForRuleSets(). Instead, just return early. Added some more tests and corrected typos from https://crrev.com/5fef4a38 Review-Url: https://codereview.chromium.org/2751193004 Cr-Commit-Position: refs/heads/master@{#457715} Committed: https://chromium.googlesource.com/chromium/src/+/2b9e4d03756be0ca4867bc1a03f8bd69f3eed43b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -8 lines) Patch
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngineTest.cpp View 3 chunks +65 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
rune
ptal
3 years, 9 months ago (2017-03-16 22:57:28 UTC) #6
nainar
lgtm. On a side note thank you for sending this patch to me - got ...
3 years, 9 months ago (2017-03-17 01:43:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751193004/1
3 years, 9 months ago (2017-03-17 08:21:21 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 08:26:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b9e4d03756be0ca4867bc1a03f8...

Powered by Google App Engine
This is Rietveld 408576698