Update reason after full paint invalidation

Update reason after full paint invalidation

This allows descendants to know the computed reason if it's different
from the original reason before paint invalidation.

This makes parent-visual-rect optimization
(https://codereview.chromium.org/2707063003/) more effective when
parent is fully invalidated because of computed full paint invalidation
reason. This is especially useful to reduce unnecessary rect
invalidations when a subtree needs full paint invalidation when the
subtree's root changes location.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2751183002
Cr-Commit-Position: refs/heads/master@{#457603}
Committed: https://chromium.googlesource.com/chromium/src/+/cb730e171a183434f93de85aa6fd2a5fc2b58fb9

[Xianzhu, 2017-03-15 19:35:59]

Description was changed from

==========
Update reason after full paint invalidation

This allows descendants to know the computed reason if it's different
from the original reason before paint invalidation.

This benefits the parent-visual-rect optimization when parent is
fully invalidated because of computed full paint invalidation reason.
==========

to

==========
Update reason after full paint invalidation

This allows descendants to know the computed reason if it's different
from the original reason before paint invalidation.

This benefits the parent-visual-rect optimization when parent is
fully invalidated because of computed full paint invalidation reason.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-03-15 19:39:40]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 19:40:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-03-15 20:54:17]

Description was changed from

==========
Update reason after full paint invalidation

This allows descendants to know the computed reason if it's different
from the original reason before paint invalidation.

This benefits the parent-visual-rect optimization when parent is
fully invalidated because of computed full paint invalidation reason.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Update reason after full paint invalidation

This allows descendants to know the computed reason if it's different
from the original reason before paint invalidation.

This makes parent-visual-rect optimization
(https://codereview.chromium.org/2707063003/) more effective when
parent is fully invalidated because of computed full paint invalidation
reason. This is especially useful to reduce unnecessary rect
invalidations when a subtree needs full paint invalidation when the
subtree's root changes location.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-03-15 20:56:31]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[Xianzhu, 2017-03-15 20:56:31]

The failed paint invalidation tests produce fewer invalidations for child rects
that are covered by parent rects.
 
Will rebaseline the tests in the next patch set.

[commit-bot: I haz the power, 2017-03-15 21:03:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 21:03:39]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Xianzhu, 2017-03-15 22:40:46]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 22:41:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-03-15 23:08:35]

LGTM

[commit-bot: I haz the power, 2017-03-16 00:25:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 00:25:08]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2017-03-16 01:20:43]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-03-16 01:20:47]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2751183002/#ps40001
(title: "rebaseline-cl")

[commit-bot: I haz the power, 2017-03-16 01:21:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 04:35:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 04:35:45]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2017-03-16 05:03:53]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-03-16 05:03:55]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2751183002/#ps60001
(title: "rebaseline-cl")

[commit-bot: I haz the power, 2017-03-16 05:04:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 05:34:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 05:34:51]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Xianzhu, 2017-03-16 06:03:25]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-03-16 06:03:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 06:22:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 06:22:53]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2017-03-16 18:54:45]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-03-16 18:55:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 21:44:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 21:44:13]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-03-16 21:47:12]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-03-16 21:47:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 23:25:16]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489700832805410,
"parent_rev": "ce0eb87c0601121d065792c19c487a4580b4dd3e", "commit_rev":
"cb730e171a183434f93de85aa6fd2a5fc2b58fb9"}

[commit-bot: I haz the power, 2017-03-16 23:26:00]

Description was changed from

==========
Update reason after full paint invalidation

This allows descendants to know the computed reason if it's different
from the original reason before paint invalidation.

This makes parent-visual-rect optimization
(https://codereview.chromium.org/2707063003/) more effective when
parent is fully invalidated because of computed full paint invalidation
reason. This is especially useful to reduce unnecessary rect
invalidations when a subtree needs full paint invalidation when the
subtree's root changes location.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Update reason after full paint invalidation

This allows descendants to know the computed reason if it's different
from the original reason before paint invalidation.

This makes parent-visual-rect optimization
(https://codereview.chromium.org/2707063003/) more effective when
parent is fully invalidated because of computed full paint invalidation
reason. This is especially useful to reduce unnecessary rect
invalidations when a subtree needs full paint invalidation when the
subtree's root changes location.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2751183002
Cr-Commit-Position: refs/heads/master@{#457603}
Committed:
https://chromium.googlesource.com/chromium/src/+/cb730e171a183434f93de85aa6fd...
==========

[commit-bot: I haz the power, 2017-03-16 23:26:01]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cb730e171a183434f93de85aa6fd...

[qyearsley, 2017-03-17 00:22:47]

On 2017/03/16 at 23:26:01, commit-bot wrote:
> Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cb730e171a183434f93de85aa6fd...

Quick note, a couple layout tests may have started failing on Mac10.12 after
this:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.12

[brucedawson, 2017-03-17 00:38:22]

On 2017/03/17 00:22:47, qyearsley wrote:
> On 2017/03/16 at 23:26:01, commit-bot wrote:
> > Committed patchset #4 (id:60001) as
>
https://chromium.googlesource.com/chromium/src/+/cb730e171a183434f93de85aa6fd...
> 
> Quick note, a couple layout tests may have started failing on Mac10.12 after
> this:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.12

And ExtensionMessageBubbleViewBrowserTest.TestClickingLearnMoreButton also, on
Mac10.11:

https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.11%20Tests...

[Xianzhu, 2017-03-17 00:45:13]

On 2017/03/17 00:38:22, brucedawson wrote:
> On 2017/03/17 00:22:47, qyearsley wrote:
> > On 2017/03/16 at 23:26:01, commit-bot wrote:
> > > Committed patchset #4 (id:60001) as
> >
>
https://chromium.googlesource.com/chromium/src/+/cb730e171a183434f93de85aa6fd...
> > 
> > Quick note, a couple layout tests may have started failing on Mac10.12 after
> > this:
> > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.12
> 
> And ExtensionMessageBubbleViewBrowserTest.TestClickingLearnMoreButton also, on
> Mac10.11:
> 
>
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.11%20Tests...

ExtensionMessageBubbleViewBrowserTest.TestClickingLearnMoreButton is unrelated.
It had flakily failed before this CL: 
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.11%20Tests

[Xianzhu, 2017-03-17 00:45:37]

On 2017/03/17 00:22:47, qyearsley wrote:
> On 2017/03/16 at 23:26:01, commit-bot wrote:
> > Committed patchset #4 (id:60001) as
>
https://chromium.googlesource.com/chromium/src/+/cb730e171a183434f93de85aa6fd...
> 
> Quick note, a couple layout tests may have started failing on Mac10.12 after
> this:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.12

Bug of rebaseline-cl? Will try to rebaseline again.