Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 2751143003: Move FrameFetchContext::dispatchDidLoadResourceFromMemoryCache logic into ResourceFetcher (Closed)

Created:
1 year, 1 month ago by kinuko
Modified:
1 year ago
CC:
chromium-reviews, Yoav Weiss, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin, hiroshige
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move FrameFetchContext::dispatchDidLoadResourceFromMemoryCache logic into ResourceFetcher Motivation: want to make FrameFetchContext thinner that only has the code that hides Frame abstraction BUG=695279 Review-Url: https://codereview.chromium.org/2751143003 Cr-Commit-Position: refs/heads/master@{#460676} Committed: https://chromium.googlesource.com/chromium/src/+/918293741a54580488930933602b2d4984378b97

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 10

Patch Set 5 : addressed comments #

Messages

Total messages: 46 (35 generated)
kinuko
What do you think? Code moving only, similar change to crrev.com/2747203002/ https://codereview.chromium.org/2751143003/diff/60001/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (right): ...
1 year ago (2017-03-22 14:13:27 UTC) #24
Nate Chapin
Awesome! https://codereview.chromium.org/2751143003/diff/60001/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (right): https://codereview.chromium.org/2751143003/diff/60001/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp#newcode464 third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:464: probe::markResourceAsCached(frame(), identifier); Is it important to do this ...
1 year ago (2017-03-22 19:02:02 UTC) #25
yhirano
lgtm if Nate's comments are addressed.
1 year ago (2017-03-23 12:07:23 UTC) #26
kinuko
Thanks! Updated. https://codereview.chromium.org/2751143003/diff/60001/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (right): https://codereview.chromium.org/2751143003/diff/60001/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp#newcode464 third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:464: probe::markResourceAsCached(frame(), identifier); On 2017/03/22 19:02:02, Nate Chapin ...
1 year ago (2017-03-24 13:51:51 UTC) #29
Nate Chapin
LGTM, sorry for the delay.
1 year ago (2017-03-28 21:50:02 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751143003/80001
1 year ago (2017-03-29 00:09:48 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/393659)
1 year ago (2017-03-29 00:24:44 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751143003/80001
1 year ago (2017-03-29 05:51:20 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/393861)
1 year ago (2017-03-29 06:59:47 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751143003/80001
1 year ago (2017-03-30 04:39:44 UTC) #43
commit-bot: I haz the power
1 year ago (2017-03-30 05:56:14 UTC) #46
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/918293741a54580488930933602b...

Powered by Google App Engine
This is Rietveld 408576698