Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2751123002: Fix padding on Add Supervised User button (Closed)

Created:
3 years, 9 months ago by Greg Levin
Modified:
3 years, 9 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix padding on Add Supervised User button BUG=700064 TEST=On login screen, click [...] button, observe that horizontal padding on "Add supervised user" button is similar to other shelf buttons (16px). CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2751123002 Cr-Commit-Position: refs/heads/master@{#459091} Committed: https://chromium.googlesource.com/chromium/src/+/e319aa3140da1136776ae4a2f2f843156ad0576b

Patch Set 1 #

Patch Set 2 : Add 1px to padding #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/resources/chromeos/login/header_bar.css View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
Greg Levin
Please take a look!
3 years, 9 months ago (2017-03-15 15:42:37 UTC) #3
achuithb
lgtm
3 years, 9 months ago (2017-03-15 18:39:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751123002/20001
3 years, 9 months ago (2017-03-23 14:31:23 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 15:36:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e319aa3140da1136776ae4a2f2f8...

Powered by Google App Engine
This is Rietveld 408576698