Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2751063004: bindings: Stop using strings directly when throwing exceptions (Closed)

Created:
3 years, 9 months ago by Raphael Kubo da Costa (rakuco)
Modified:
3 years, 9 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Stop using strings directly when throwing exceptions Replace occurrences of "raise 'foo bar'" with "raise ValueError('foo bar')", otherwise we get another exception ourselves: TypeError: exceptions must be old-style classes or derived from BaseException, not str R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org Review-Url: https://codereview.chromium.org/2751063004 Cr-Commit-Position: refs/heads/master@{#457401} Committed: https://chromium.googlesource.com/chromium/src/+/f35532b8b4f9c1be7dde2a464071b4730122e3a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/bindings/scripts/idl_types.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_types.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Raphael Kubo da Costa (rakuco)
PTAL
3 years, 9 months ago (2017-03-16 10:34:01 UTC) #2
haraken
LGTM
3 years, 9 months ago (2017-03-16 10:36:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751063004/1
3 years, 9 months ago (2017-03-16 12:01:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f35532b8b4f9c1be7dde2a464071b4730122e3a6
3 years, 9 months ago (2017-03-16 12:07:34 UTC) #11
bashi
lgtm
3 years, 9 months ago (2017-03-16 12:20:11 UTC) #12
Yuki
3 years, 9 months ago (2017-03-16 13:29:14 UTC) #13
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698