Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2751063003: [MD settings] move font controls in MD settings (Closed)

Created:
3 years, 9 months ago by dschuyler
Modified:
3 years, 9 months ago
Reviewers:
tommycli, Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] move font controls in MD settings This CL outdents some UI controlls to place them in the correct positions (they were indented too far). Also corrects some div tags. BUG=617712 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2751063003 Cr-Commit-Position: refs/heads/master@{#457280} Committed: https://chromium.googlesource.com/chromium/src/+/566e65ab665604104285fc725c65753423b1cb92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -78 lines) Patch
M chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html View 2 chunks +82 lines, -78 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
dschuyler
screen shots at: http://imgur.com/a/YXwIg
3 years, 9 months ago (2017-03-15 21:44:02 UTC) #4
dschuyler
3 years, 9 months ago (2017-03-15 21:44:43 UTC) #6
tommycli
looks like all whitespace changes and adding back some missing brackets. Does that sound accurate? ...
3 years, 9 months ago (2017-03-15 23:22:32 UTC) #7
tommycli
err looks like you're also adding and removing some div tags. Overall seems harmless. lgtm ...
3 years, 9 months ago (2017-03-15 23:23:33 UTC) #8
Dan Beam
lgtm
3 years, 9 months ago (2017-03-15 23:41:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751063003/1
3 years, 9 months ago (2017-03-16 00:18:03 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 00:25:39 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/566e65ab665604104285fc725c65...

Powered by Google App Engine
This is Rietveld 408576698