Revert of Migrate WTF::Deque::remove() to ::erase()

Revert of Migrate WTF::Deque::remove() to ::erase() (patchset #1 id:1 of https://codereview.chromium.org/2747373004/ )

Reason for revert:
This CL is suspected of crashing
  WebSiteSettingsPopupViewBrowserTest.ChromeURL
for chromium.linux/Linux Tests (dbg)(1). Justifications:
- This is the first failure in a long time.
- This CL is the only C++ CL in the batch.
- Crash occurs in a destructor, and this CL deals with deallocation.

Original issue's description:
> Migrate WTF::Deque::remove() to ::erase()
> 
> As discussed on platform-architecture-dev [0], there is interest in
> normalizing the methods of WTF classes to better align with std classes.
> 
> There are no functional changes.
> 
> [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion
> 
> BUG=662431
> 
> Review-Url: https://codereview.chromium.org/2747373004
> Cr-Commit-Position: refs/heads/master@{#457097}
> Committed: https://chromium.googlesource.com/chromium/src/+/e1dd04d3aa422d619a76153946c2cf0061ed4e43

TBR=esprehn@chromium.org,haraken@chromium.org,yutak@chromium.org,pilgrim@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=662431

[huangs, 2017-03-15 18:20:56]

The CQ bit was checked by huangs@chromium.org

[huangs, 2017-03-15 18:20:56]

Created Revert of Migrate WTF::Deque::remove() to ::erase()

[commit-bot: I haz the power, 2017-03-15 18:21:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 18:27:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 18:27:06]

Failed to apply patch for
third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp:355
  error: third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp:
patch does not apply

Patch:       third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp
Index: third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp
b/third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp
index
8ecb8159cfc35e4b9ec4a0b72497426fded8f727..df7e4ede8dbdfcf8b84a20166e2355829021a385
100644
--- a/third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp
@@ -355,7 +355,7 @@
       continue;
     if (it != styleSharingList.begin()) {
       // Move the element to the front of the LRU
-      styleSharingList.erase(it);
+      styleSharingList.remove(it);
       styleSharingList.prepend(&candidate);
     }
     return &candidate;

[huangs, 2017-03-15 18:38:12]

Merged failed due to https://codereview.chromium.org/2746763009/ , but
WebSiteSettingsPopupViewBrowserTest.ChromeURL crash also disappeared.  Closing
CL for now.

[huangs, 2017-03-15 18:38:36]

Description was changed from

==========
Revert of Migrate WTF::Deque::remove() to ::erase() (patchset #1 id:1 of
https://codereview.chromium.org/2747373004/ )

Reason for revert:
This CL is suspected of crashing
  WebSiteSettingsPopupViewBrowserTest.ChromeURL
for chromium.linux/Linux Tests (dbg)(1). Justifications:
- This is the first failure in a long time.
- This CL is the only C++ CL in the batch.
- Crash occurs in a destructor, and this CL deals with deallocation.

Original issue's description:
> Migrate WTF::Deque::remove() to ::erase()
> 
> As discussed on platform-architecture-dev [0], there is interest in
> normalizing the methods of WTF classes to better align with std classes.
> 
> There are no functional changes.
> 
> [0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...
> 
> BUG=662431
> 
> Review-Url: https://codereview.chromium.org/2747373004
> Cr-Commit-Position: refs/heads/master@{#457097}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e1dd04d3aa422d619a76153946c2...

TBR=esprehn@chromium.org,haraken@chromium.org,yutak@chromium.org,pilgrim@chro...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=662431
==========

to

==========
Revert of Migrate WTF::Deque::remove() to ::erase() (patchset #1 id:1 of
https://codereview.chromium.org/2747373004/ )

Reason for revert:
This CL is suspected of crashing
  WebSiteSettingsPopupViewBrowserTest.ChromeURL
for chromium.linux/Linux Tests (dbg)(1). Justifications:
- This is the first failure in a long time.
- This CL is the only C++ CL in the batch.
- Crash occurs in a destructor, and this CL deals with deallocation.

Original issue's description:
> Migrate WTF::Deque::remove() to ::erase()
> 
> As discussed on platform-architecture-dev [0], there is interest in
> normalizing the methods of WTF classes to better align with std classes.
> 
> There are no functional changes.
> 
> [0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...
> 
> BUG=662431
> 
> Review-Url: https://codereview.chromium.org/2747373004
> Cr-Commit-Position: refs/heads/master@{#457097}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e1dd04d3aa422d619a76153946c2...

TBR=esprehn@chromium.org,haraken@chromium.org,yutak@chromium.org,pilgrim@chro...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=662431
==========