Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2751023004: SwiftShader DEPS update (Closed)

Created:
3 years, 9 months ago by sugoi1
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SwiftShader DEPS update This update disables the debugger wait dialog by default on any build not made using the SwiftShader solution in Visual Studio. TBR=kbr@chromium.org TBR_REASON=SwiftShader DEPS roll BUG=630728 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2751023004 Cr-Commit-Position: refs/heads/master@{#457468} Committed: https://chromium.googlesource.com/chromium/src/+/94537c579db2361b6f285f810cedb796650e03a1

Patch Set 1 #

Patch Set 2 : Build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751023004/20001
3 years, 9 months ago (2017-03-16 17:07:32 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/94537c579db2361b6f285f810cedb796650e03a1
3 years, 9 months ago (2017-03-16 17:19:03 UTC) #11
Ken Russell (switch to Gerrit)
Thanks for tracking down and fixing this. LGTM
3 years, 9 months ago (2017-03-16 17:31:04 UTC) #12
brucedawson
On 2017/03/16 17:31:04, Ken Russell wrote: > Thanks for tracking down and fixing this. LGTM ...
3 years, 9 months ago (2017-03-20 20:32:45 UTC) #13
sugoi1
3 years, 9 months ago (2017-03-20 20:48:07 UTC) #14
Message was sent while issue was closed.
On 2017/03/20 20:32:45, brucedawson wrote:
> On 2017/03/16 17:31:04, Ken Russell wrote:
> > Thanks for tracking down and fixing this. LGTM
> 
> When doing a DEPS roll please include a list of changes in the description,
> preferably in a clickable form. For example, from a recent SKIA roll:
> 
>     Roll src/third_party/skia/ e0a34e7dc..025a1ca73 (7 commits)
> 
>     https://skia.googlesource.com/skia.git/+log/e0a34e7dcddf..025a1ca73b19
> 
> 
> This makes it much easier to see what change(s) is being brought in. In this
> case it makes it easier to see the two changes that fixed the debugger wait
> issue, and the third change that was also (inadvertently?) brought in (Allows
> SwiftShader to identify the Android version).
> 
> The depot_tools roll-dep tool makes this task easy, although not entirely
> automatic.

Noted

Powered by Google App Engine
This is Rietveld 408576698