Issue 2750973002: Make sure lazily-loaded images have absolute URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2750973002: Make sure lazily-loaded images have absolute URL (Closed)

Created:
3 years, 9 months ago by wychen

Modified:
3 years, 9 months ago

Reviewers:
mdjones

CC:
noyau (Ping after 24h), Olivier, lody, gambard

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Make sure lazily-loaded images have absolute URL It was possible to leak relative URLs through WebImage.getUrlList(). R=mdjones@chromium.org Committed: 2d7b6290050772918dabb7b0fcffc3438c35a27b

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	java/org/chromium/distiller/webdocument/WebImage.java	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	javatests/org/chromium/distiller/EmbedExtractorTest.java	View		3 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

wychen

PTAL. Accidentally found this when doing quality eval of wikipedia.

3 years, 9 months ago (2017-03-14 23:56:59 UTC) #2

wychen

3 years, 9 months ago (2017-03-15 01:59:31 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2d7b6290050772918dabb7b0fcffc3438c35a27b (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages