Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Side by Side Diff: javatests/org/chromium/distiller/EmbedExtractorTest.java

Issue 2750973002: Make sure lazily-loaded images have absolute URL (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « java/org/chromium/distiller/webdocument/WebImage.java ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.distiller; 5 package org.chromium.distiller;
6 6
7 import com.google.gwt.dom.client.AnchorElement; 7 import com.google.gwt.dom.client.AnchorElement;
8 import com.google.gwt.dom.client.Style; 8 import com.google.gwt.dom.client.Style;
9 import java.util.ArrayList;
10 import java.util.List;
9 import org.chromium.distiller.webdocument.WebElement; 11 import org.chromium.distiller.webdocument.WebElement;
10 import org.chromium.distiller.webdocument.WebEmbed; 12 import org.chromium.distiller.webdocument.WebEmbed;
11 import org.chromium.distiller.webdocument.WebFigure; 13 import org.chromium.distiller.webdocument.WebFigure;
12 import org.chromium.distiller.webdocument.WebImage; 14 import org.chromium.distiller.webdocument.WebImage;
13 import org.chromium.distiller.extractors.embeds.EmbedExtractor; 15 import org.chromium.distiller.extractors.embeds.EmbedExtractor;
14 import org.chromium.distiller.extractors.embeds.TwitterExtractor; 16 import org.chromium.distiller.extractors.embeds.TwitterExtractor;
15 import org.chromium.distiller.extractors.embeds.VimeoExtractor; 17 import org.chromium.distiller.extractors.embeds.VimeoExtractor;
16 import org.chromium.distiller.extractors.embeds.YouTubeExtractor; 18 import org.chromium.distiller.extractors.embeds.YouTubeExtractor;
17 import org.chromium.distiller.extractors.embeds.ImageExtractor; 19 import org.chromium.distiller.extractors.embeds.ImageExtractor;
18 20
(...skipping 369 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 ImageElement image = TestUtil.createImage(); 390 ImageElement image = TestUtil.createImage();
389 image.setAttribute(attr, "image.png"); 391 image.setAttribute(attr, "image.png");
390 mBody.appendChild(image); 392 mBody.appendChild(image);
391 393
392 mHead.setInnerHTML("<base href=\"http://example.com/\">"); 394 mHead.setInnerHTML("<base href=\"http://example.com/\">");
393 395
394 EmbedExtractor extractor = new ImageExtractor(); 396 EmbedExtractor extractor = new ImageExtractor();
395 WebImage result = (WebImage) extractor.extract(image); 397 WebImage result = (WebImage) extractor.extract(image);
396 assertNotNull(result); 398 assertNotNull(result);
397 assertEquals("<img src=\"http://example.com/image.png\">", result.genera teOutput(false)); 399 assertEquals("<img src=\"http://example.com/image.png\">", result.genera teOutput(false));
400
401 List<String> expected = new ArrayList<String>();
402 expected.add("http://example.com/image.png");
403 assertEquals(expected, result.getUrlList());
398 } 404 }
399 405
400 private void extractLazilyLoadedFigure(String attr) { 406 private void extractLazilyLoadedFigure(String attr) {
401 ImageElement image = TestUtil.createImage(); 407 ImageElement image = TestUtil.createImage();
402 image.setAttribute(attr, "image.png"); 408 image.setAttribute(attr, "image.png");
403 Element figure = Document.get().createElement("FIGURE"); 409 Element figure = Document.get().createElement("FIGURE");
404 figure.appendChild(image); 410 figure.appendChild(image);
405 411
406 mBody.appendChild(figure); 412 mBody.appendChild(figure);
407 413
408 mHead.setInnerHTML("<base href=\"http://example.com/\">"); 414 mHead.setInnerHTML("<base href=\"http://example.com/\">");
409 415
410 EmbedExtractor extractor = new ImageExtractor(); 416 EmbedExtractor extractor = new ImageExtractor();
411 WebFigure result = (WebFigure) extractor.extract(figure); 417 WebFigure result = (WebFigure) extractor.extract(figure);
412 assertNotNull(result); 418 assertNotNull(result);
413 assertEquals("<figure><img src=\"http://example.com/image.png\"></figure >", 419 assertEquals("<figure><img src=\"http://example.com/image.png\"></figure >",
414 result.generateOutput(false)); 420 result.generateOutput(false));
421
422 List<String> expected = new ArrayList<String>();
423 expected.add("http://example.com/image.png");
424 assertEquals(expected, result.getUrlList());
415 } 425 }
416 426
417 public void testImageExtractorLazy() { 427 public void testImageExtractorLazy() {
418 extractLazilyLoadedImage("data-src"); 428 extractLazilyLoadedImage("data-src");
419 extractLazilyLoadedImage("datasrc"); 429 extractLazilyLoadedImage("datasrc");
420 extractLazilyLoadedImage("data-original"); 430 extractLazilyLoadedImage("data-original");
421 extractLazilyLoadedImage("data-url"); 431 extractLazilyLoadedImage("data-url");
422 432
423 extractLazilyLoadedFigure("data-src"); 433 extractLazilyLoadedFigure("data-src");
424 extractLazilyLoadedFigure("datasrc"); 434 extractLazilyLoadedFigure("datasrc");
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
582 "<img src=\"http://wwww.example.com/image.jpeg\"" + 592 "<img src=\"http://wwww.example.com/image.jpeg\"" +
583 " width=\"100\" height=\"100\">" + 593 " width=\"100\" height=\"100\">" +
584 "<figcaption>\nThis is a caption</figcaption>" + 594 "<figcaption>\nThis is a caption</figcaption>" +
585 "</figure>"; 595 "</figure>";
586 EmbedExtractor extractor = new ImageExtractor(); 596 EmbedExtractor extractor = new ImageExtractor();
587 WebElement result = extractor.extract(figure); 597 WebElement result = extractor.extract(figure);
588 assertEquals(expected, TestUtil.removeAllDirAttributes( 598 assertEquals(expected, TestUtil.removeAllDirAttributes(
589 result.generateOutput(false))); 599 result.generateOutput(false)));
590 } 600 }
591 } 601 }
OLDNEW
« no previous file with comments | « java/org/chromium/distiller/webdocument/WebImage.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698