[MD setings] setting people menu icon

[MD setings] setting people menu icon

This CL changes the icon on the side nav menu from the 'people' icon to
the 'person' icon, as requested by UI designer.

BUG=689251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2750943003
Cr-Commit-Position: refs/heads/master@{#456887}
Committed: https://chromium.googlesource.com/chromium/src/+/086b8855ab10dd52271b283c7220922e9d680054

[dschuyler, 2017-03-14 21:12:50]

Description was changed from

==========
[MD setings] setting people menu icon

This CL changes the icon on the side nav menu from the 'people' icon to
the 'person' icon, as requested by UI designer.

BUG=689251
==========

to

==========
[MD setings] setting people menu icon

This CL changes the icon on the side nav menu from the 'people' icon to
the 'person' icon, as requested by UI designer.

BUG=689251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-03-14 21:12:56]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 21:14:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-03-14 21:16:20]

dschuyler@chromium.org changed reviewers:
+ hcarmona@chromium.org

[dschuyler, 2017-03-14 21:16:21]

https://codereview.chromium.org/2750943003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/icons.html (left):

https://codereview.chromium.org/2750943003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/icons.html:93: <g id="people"><path d="M16
11c1.66 0 2.99-1.34 2.99-3S17.66 5 16 5c-1.66 0-3 1.34-3 3s1.34 3 3 3zm-8 0c1.66
0 2.99-1.34 2.99-3S9.66 5 8 5C6.34 5 5 6.34 5 8s1.34 3 3 3zm0 2c-2.33 0-7 1.17-7
3.5V19h14v-2.5c0-2.33-4.67-3.5-7-3.5zm8 0c-.29 0-.62.02-.97.05 1.16.84 1.97 1.97
1.97 3.45V19h6v-2.5c0-2.33-4.67-3.5-7-3.5z"></path></g>
I tried searching for settings:people and '"people"' and didn't come up with any
hits, so I think this is now unused.

[commit-bot: I haz the power, 2017-03-14 22:42:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 22:42:03]

Dry run: This issue passed the CQ dry run.

[hcarmona, 2017-03-14 23:08:33]

LGTM, just had a question for my own curiosity.

https://codereview.chromium.org/2750943003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/icons.html (left):

https://codereview.chromium.org/2750943003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/icons.html:93: <g id="people"><path d="M16
11c1.66 0 2.99-1.34 2.99-3S17.66 5 16 5c-1.66 0-3 1.34-3 3s1.34 3 3 3zm-8 0c1.66
0 2.99-1.34 2.99-3S9.66 5 8 5C6.34 5 5 6.34 5 8s1.34 3 3 3zm0 2c-2.33 0-7 1.17-7
3.5V19h14v-2.5c0-2.33-4.67-3.5-7-3.5zm8 0c-.29 0-.62.02-.97.05 1.16.84 1.97 1.97
1.97 3.45V19h6v-2.5c0-2.33-4.67-3.5-7-3.5z"></path></g>
On 2017/03/14 21:16:20, dschuyler wrote:
> I tried searching for settings:people and '"people"' and didn't come up with
any
> hits, so I think this is now unused.

Sounds good. Just wondering what happens when someone references an icon that
doesn't exist? missing image or blank?

[dschuyler, 2017-03-14 23:15:32]

https://codereview.chromium.org/2750943003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/icons.html (left):

https://codereview.chromium.org/2750943003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/icons.html:93: <g id="people"><path d="M16
11c1.66 0 2.99-1.34 2.99-3S17.66 5 16 5c-1.66 0-3 1.34-3 3s1.34 3 3 3zm-8 0c1.66
0 2.99-1.34 2.99-3S9.66 5 8 5C6.34 5 5 6.34 5 8s1.34 3 3 3zm0 2c-2.33 0-7 1.17-7
3.5V19h14v-2.5c0-2.33-4.67-3.5-7-3.5zm8 0c-.29 0-.62.02-.97.05 1.16.84 1.97 1.97
1.97 3.45V19h6v-2.5c0-2.33-4.67-3.5-7-3.5z"></path></g>
On 2017/03/14 23:08:32, hcarmona wrote:
> On 2017/03/14 21:16:20, dschuyler wrote:
> > I tried searching for settings:people and '"people"' and didn't come up with
> any
> > hits, so I think this is now unused.
> 
> Sounds good. Just wondering what happens when someone references an icon that
> doesn't exist? missing image or blank?

It shows up blank from my experience. (There's not a broken image icon or
similar).

[dschuyler, 2017-03-14 23:15:36]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-03-14 23:16:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 23:24:23]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489533336105940, "parent_rev":
"126f704d1c44627098d024123ade6466bde7825f", "commit_rev":
"086b8855ab10dd52271b283c7220922e9d680054"}

[commit-bot: I haz the power, 2017-03-14 23:25:57]

Description was changed from

==========
[MD setings] setting people menu icon

This CL changes the icon on the side nav menu from the 'people' icon to
the 'person' icon, as requested by UI designer.

BUG=689251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD setings] setting people menu icon

This CL changes the icon on the side nav menu from the 'people' icon to
the 'person' icon, as requested by UI designer.

BUG=689251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2750943003
Cr-Commit-Position: refs/heads/master@{#456887}
Committed:
https://chromium.googlesource.com/chromium/src/+/086b8855ab10dd52271b283c7220...
==========

[commit-bot: I haz the power, 2017-03-14 23:25:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/086b8855ab10dd52271b283c7220...