Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2750943003: [MD setings] setting people menu icon (Closed)

Created:
3 years, 9 months ago by dschuyler
Modified:
3 years, 9 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD setings] setting people menu icon This CL changes the icon on the side nav menu from the 'people' icon to the 'person' icon, as requested by UI designer. BUG=689251 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2750943003 Cr-Commit-Position: refs/heads/master@{#456887} Committed: https://chromium.googlesource.com/chromium/src/+/086b8855ab10dd52271b283c7220922e9d680054

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/resources/settings/icons.html View 2 chunks +3 lines, -1 line 3 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
dschuyler
https://codereview.chromium.org/2750943003/diff/1/chrome/browser/resources/settings/icons.html File chrome/browser/resources/settings/icons.html (left): https://codereview.chromium.org/2750943003/diff/1/chrome/browser/resources/settings/icons.html#oldcode93 chrome/browser/resources/settings/icons.html:93: <g id="people"><path d="M16 11c1.66 0 2.99-1.34 2.99-3S17.66 5 16 ...
3 years, 9 months ago (2017-03-14 21:16:21 UTC) #5
hcarmona
LGTM, just had a question for my own curiosity. https://codereview.chromium.org/2750943003/diff/1/chrome/browser/resources/settings/icons.html File chrome/browser/resources/settings/icons.html (left): https://codereview.chromium.org/2750943003/diff/1/chrome/browser/resources/settings/icons.html#oldcode93 chrome/browser/resources/settings/icons.html:93: ...
3 years, 9 months ago (2017-03-14 23:08:33 UTC) #8
dschuyler
https://codereview.chromium.org/2750943003/diff/1/chrome/browser/resources/settings/icons.html File chrome/browser/resources/settings/icons.html (left): https://codereview.chromium.org/2750943003/diff/1/chrome/browser/resources/settings/icons.html#oldcode93 chrome/browser/resources/settings/icons.html:93: <g id="people"><path d="M16 11c1.66 0 2.99-1.34 2.99-3S17.66 5 16 ...
3 years, 9 months ago (2017-03-14 23:15:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750943003/1
3 years, 9 months ago (2017-03-14 23:16:20 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 23:25:59 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/086b8855ab10dd52271b283c7220...

Powered by Google App Engine
This is Rietveld 408576698