Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2750913003:
Add temporary debugging to make_hfs.sh. (Closed)
DescriptionAdd temporary debugging to make_hfs.sh.
This will tell us about all available disk images, as well as specifics about
the RAMDISK being mounted.
BUG=696529
Review-Url: https://codereview.chromium.org/2750913003
Cr-Commit-Position: refs/heads/master@{#456956}
Committed: https://chromium.googlesource.com/chromium/src/+/3824c55fa682cafe038041adc75a0d478717dbca
Patch Set 1 #Patch Set 2 : switch from -diagnostic to -complete #Patch Set 3 : Add -debug while I'm at it. #Messages
Total messages: 23 (12 generated)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
erikchen@chromium.org changed reviewers: + thakis@chromium.org
thakis: Please review.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
thakis@chromium.org changed reviewers: + rsesek@chromium.org
Is the red trybot enough? Lgtm, but it's rsesek's script. The leading 2>& looks weird.
On 2017/03/15 00:31:17, Nico wrote: > Is the red trybot enough? > > Lgtm, but it's rsesek's script. The leading 2>& looks weird. blergh, -diagnostic isn't available in 10.11 or older.
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
On 2017/03/15 00:32:59, erikchen wrote: > On 2017/03/15 00:31:17, Nico wrote: > > Is the red trybot enough? > > > > Lgtm, but it's rsesek's script. The leading 2>& looks weird. > > blergh, -diagnostic isn't available in 10.11 or older. I wanted to see the output both for successful and unsuccessful runs. Hence the >&2 to redirect to stderr.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On Tue, Mar 14, 2017 at 8:36 PM, <erikchen@chromium.org> wrote: > On 2017/03/15 00:32:59, erikchen wrote: > > On 2017/03/15 00:31:17, Nico wrote: > > > Is the red trybot enough? > > > > > > Lgtm, but it's rsesek's script. The leading 2>& looks weird. > > > > blergh, -diagnostic isn't available in 10.11 or older. > I guess you can check for the os version, sounds like the Mac main waterfall bot has a new macOS version. > > I wanted to see the output both for successful and unsuccessful runs. > Hence the > >&2 to redirect to stderr. > Yeah, but I've only seen that at the end of the command so far, never at the start. > > https://codereview.chromium.org/2750913003/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2017/03/15 00:36:20, erikchen wrote: > On 2017/03/15 00:32:59, erikchen wrote: > > On 2017/03/15 00:31:17, Nico wrote: > > > Is the red trybot enough? > > > > > > Lgtm, but it's rsesek's script. The leading 2>& looks weird. > > > > blergh, -diagnostic isn't available in 10.11 or older. Heck, might as well add "-debug" while I'm at it.
> Yeah, but I've only seen that at the end of the command so far, never at > the start. Has the same effect at the front: http://stackoverflow.com/questions/2990414/echo-that-outputs-to-stderr
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/2750913003/#ps40001 (title: "Add -debug while I'm at it.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489538617359710,
"parent_rev": "36357edbe55f8bb1c434a2c377b4692a19ec7168", "commit_rev":
"3824c55fa682cafe038041adc75a0d478717dbca"}
Message was sent while issue was closed.
Description was changed from ========== Add temporary debugging to make_hfs.sh. This will tell us about all available disk images, as well as specifics about the RAMDISK being mounted. BUG=696529 ========== to ========== Add temporary debugging to make_hfs.sh. This will tell us about all available disk images, as well as specifics about the RAMDISK being mounted. BUG=696529 Review-Url: https://codereview.chromium.org/2750913003 Cr-Commit-Position: refs/heads/master@{#456956} Committed: https://chromium.googlesource.com/chromium/src/+/3824c55fa682cafe038041adc75a... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/3824c55fa682cafe038041adc75a...
Message was sent while issue was closed.
On Tue, Mar 14, 2017 at 8:43 PM, <erikchen@chromium.org> wrote: > > > Yeah, but I've only seen that at the end of the command so far, never at > > the start. > > Has the same effect at the front: > http://stackoverflow.com/questions/2990414/echo-that-outputs-to-stderr > I didn't say that it didn't work, just that it looked weird. It's temporary code so I don't mind. > > > https://codereview.chromium.org/2750913003/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
lgtm |
