Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2750853005: Fix crash when removing all notifications by "Clear all" button. (Closed)

Created:
3 years, 9 months ago by yhanada
Modified:
3 years, 9 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, Peter Beverloo, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when removing all notifications by "Clear all" button. BUG=701348 Review-Url: https://codereview.chromium.org/2750853005 Cr-Commit-Position: refs/heads/master@{#457005} Committed: https://chromium.googlesource.com/chromium/src/+/9f177cc7d313503e07a143337105868ef182022b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/arc/notification/arc_custom_notification_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/message_center/message_center_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
yhanada
PTAL.
3 years, 9 months ago (2017-03-15 05:15:40 UTC) #4
yoshiki
lgtm Thanks!
3 years, 9 months ago (2017-03-15 05:16:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750853005/1
3 years, 9 months ago (2017-03-15 05:58:07 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 06:04:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9f177cc7d313503e07a143337105...

Powered by Google App Engine
This is Rietveld 408576698