Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2750853003: cc: Remove friend class TransformTree from PropertyTree (Closed)

Created:
3 years, 9 months ago by weiliangc
Modified:
3 years, 9 months ago
Reviewers:
ajuma
CC:
cc-bugs_chromium.org, chromium-reviews, danakj, jaydasika
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove friend class TransformTree from PropertyTree In transform tree, call the base class instead of accessing private. BUG=695681 R=ajuma CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2750853003 Cr-Commit-Position: refs/heads/master@{#456879} Committed: https://chromium.googlesource.com/chromium/src/+/0d18473730c4e536b78ad19abec5358945aaa757

Patch Set 1 : oops left other code in previous patchset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M cc/trees/property_tree.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/property_tree.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
weiliangc
Property Tree don't need no friend!
3 years, 9 months ago (2017-03-14 21:20:40 UTC) #3
ajuma
lgtm
3 years, 9 months ago (2017-03-14 21:23:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750853003/20001
3 years, 9 months ago (2017-03-14 21:24:35 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 23:05:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0d18473730c4e536b78ad19abec5...

Powered by Google App Engine
This is Rietveld 408576698