Flush TaskScheduler in content::RunAllBlockingPoolTasksUntilIdle().

Flush TaskScheduler in content::RunAllBlockingPoolTasksUntilIdle().

Since all blocking pool call sites are being migrated to TaskScheduler,
it makes sense to flush TaskScheduler in
content::RunAllBlockingPoolTasksUntilIdle().

Once the blocking pool is fully deprecated,
content::RunAllBlockingPoolTasksUntilIdle() will be renamed to
content::RunAllTaskSchedulerTasksUntilidle().

BUG=667892, 697662
Review-Url: https://codereview.chromium.org/2750823002
Cr-Commit-Position: refs/heads/master@{#461440}
Committed: https://chromium.googlesource.com/chromium/src/+/b1e1115ec2ca636a0744eae2c442ef22bb844d41

[fdoray, 2017-03-14 13:49:01]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org, robliao@chromium.org

[fdoray, 2017-03-14 13:49:02]

PTAL

[gab, 2017-03-15 19:17:35]

lgtm, please also file bug for issue reported by thakis@ on chromium-dev (if
none already) and associate it with this issue.

[fdoray, 2017-03-15 20:20:58]

Description was changed from

==========
Flush TaskScheduler in content::RunAllBlockingPoolTasksUntilIdle().

Since all blocking pool call sites are being migrated to TaskScheduler,
it makes sense to flush TaskScheduler in
content::RunAllBlockingPoolTasksUntilIdle().

Once the blocking pool is fully deprecated,
content::RunAllBlockingPoolTasksUntilIdle() will be renamed to
content::RunAllTaskSchedulerTasksUntilidle().

BUG=667892
==========

to

==========
Flush TaskScheduler in content::RunAllBlockingPoolTasksUntilIdle().

Since all blocking pool call sites are being migrated to TaskScheduler,
it makes sense to flush TaskScheduler in
content::RunAllBlockingPoolTasksUntilIdle().

Once the blocking pool is fully deprecated,
content::RunAllBlockingPoolTasksUntilIdle() will be renamed to
content::RunAllTaskSchedulerTasksUntilidle().

BUG=667892, 697662
==========

[fdoray, 2017-03-15 20:23:41]

On 2017/03/15 19:17:35, gab wrote:
> lgtm, please also file bug for issue reported by thakis@ on chromium-dev (if
> none already) and associate it with this issue.

Done. The bug reported by thakis@ is https://crbug.com/697662. It was fixed by
waiting on a specific task. This CL will avoid future errors rather than fixing
this specific error.

[fdoray, 2017-03-15 20:23:59]

fdoray@chromium.org changed reviewers:
+ sky@chromium.org

[fdoray, 2017-03-15 20:24:00]

sky@: PTAL

[sky, 2017-03-15 23:03:01]

LGTM

[fdoray, 2017-03-16 10:41:50]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-03-16 10:42:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 11:14:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 11:14:51]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2017-03-16 12:35:51]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-03-16 12:35:51]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2750823002/#ps40001
(title: "add rununtilidle in TestTaskScheduler::FlushForTesting")

[commit-bot: I haz the power, 2017-03-16 12:36:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 13:45:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 13:45:17]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[robliao, 2017-03-17 01:00:14]

https://codereview.chromium.org/2750823002/diff/40001/content/public/test/tes...
File content/public/test/test_utils.cc (right):

https://codereview.chromium.org/2750823002/diff/40001/content/public/test/tes...
content/public/test/test_utils.cc:161: // Flush blocking pool tasks.
Remove this comment as it's stating what the next line does.

Alternatively, you can have a banner comment that discusses the postcondition of
this function (all inflight tasks are done at the end of this call and enumerate
the sources).

An interesting non-obvious comment would be why we do this with the MessageLoop
in the third section as we've just dealt with the BlockingPool.

[fdoray, 2017-03-21 16:56:56]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 16:57:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 17:43:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 17:44:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2017-03-21 18:01:02]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 18:01:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 18:36:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 18:36:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2017-03-22 13:13:43]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 13:13:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 14:06:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 14:06:11]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[fdoray, 2017-03-31 20:25:47]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2017-03-31 20:26:05]

https://codereview.chromium.org/2750823002/diff/40001/content/public/test/tes...
File content/public/test/test_utils.cc (right):

https://codereview.chromium.org/2750823002/diff/40001/content/public/test/tes...
content/public/test/test_utils.cc:161: // Flush blocking pool tasks.
On 2017/03/17 01:00:14, robliao wrote:
> Remove this comment as it's stating what the next line does.
> 
> Alternatively, you can have a banner comment that discusses the postcondition
of
> this function (all inflight tasks are done at the end of this call and
enumerate
> the sources).
> 
> An interesting non-obvious comment would be why we do this with the
MessageLoop
> in the third section as we've just dealt with the BlockingPool.

Removed unnecessary comment.

I have a few CLs to land:
1. Flush TaskScheduler in RunAllBlockingPoolTasksUntilIdle (this CL).
2. Always use an async TaskScheduler in TestBrowserThreadBundle.
3. Enable redirection of SequencedWorkerPool to TaskScheduler in
TestBrowserThreadBundle.
4. Remove content::BrowserThread::GetBlockingPool()->FlushForTesting(); from
this function.

I'd like to wait until 4. to work on the comments in this function, because
they'll have to be updated anyways.

[commit-bot: I haz the power, 2017-03-31 20:26:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 22:14:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 22:14:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2017-04-03 14:38:26]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-04-03 14:38:27]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2750823002/#ps140001
(title: "fix test error")

[commit-bot: I haz the power, 2017-04-03 14:38:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 15:45:05]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1491230306575080,
"parent_rev": "9e717eb017b6ad11e6c580518a7074c6f56f6c5f", "commit_rev":
"b1e1115ec2ca636a0744eae2c442ef22bb844d41"}

[commit-bot: I haz the power, 2017-04-03 15:45:46]

Description was changed from

==========
Flush TaskScheduler in content::RunAllBlockingPoolTasksUntilIdle().

Since all blocking pool call sites are being migrated to TaskScheduler,
it makes sense to flush TaskScheduler in
content::RunAllBlockingPoolTasksUntilIdle().

Once the blocking pool is fully deprecated,
content::RunAllBlockingPoolTasksUntilIdle() will be renamed to
content::RunAllTaskSchedulerTasksUntilidle().

BUG=667892, 697662
==========

to

==========
Flush TaskScheduler in content::RunAllBlockingPoolTasksUntilIdle().

Since all blocking pool call sites are being migrated to TaskScheduler,
it makes sense to flush TaskScheduler in
content::RunAllBlockingPoolTasksUntilIdle().

Once the blocking pool is fully deprecated,
content::RunAllBlockingPoolTasksUntilIdle() will be renamed to
content::RunAllTaskSchedulerTasksUntilidle().

BUG=667892, 697662

Review-Url: https://codereview.chromium.org/2750823002
Cr-Commit-Position: refs/heads/master@{#461440}
Committed:
https://chromium.googlesource.com/chromium/src/+/b1e1115ec2ca636a0744eae2c442...
==========

[commit-bot: I haz the power, 2017-04-03 15:45:47]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/b1e1115ec2ca636a0744eae2c442...