Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 2750803002: [turbofan] Add more error reporting to representation changer. (Closed)

Created:
3 years, 9 months ago by Jarin
Modified:
3 years, 9 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add more error reporting to representation changer. BUG=chromium:700883 Review-Url: https://codereview.chromium.org/2750803002 Cr-Commit-Position: refs/heads/master@{#43785} Committed: https://chromium.googlesource.com/v8/v8/+/39e147593fc617e19d73222a5e1327876eb84483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M src/compiler/representation-change.cc View 6 chunks +28 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Jarin
Could you take a look, please?
3 years, 9 months ago (2017-03-14 13:27:29 UTC) #7
neis
lgtm
3 years, 9 months ago (2017-03-14 13:45:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750803002/1
3 years, 9 months ago (2017-03-14 13:51:22 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 13:54:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/39e147593fc617e19d73222a5e1327876eb...

Powered by Google App Engine
This is Rietveld 408576698