Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2750763006: Correct misnamed WebVR event in tests (Closed)

Created:
3 years, 9 months ago by bsheedy
Modified:
3 years, 9 months ago
Reviewers:
Sami
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct misnamed WebVR event in tests Tests were incorrectly using/referring to 'onvrdisplayactivate' and 'onvrdisplaypresentchange' instead of 'vrdisplayactivate' and 'vrdisplaypresentchange'. BUG= Review-Url: https://codereview.chromium.org/2750763006 Cr-Commit-Position: refs/heads/master@{#457460} Committed: https://chromium.googlesource.com/chromium/src/+/ea7cb15bc1df999bd8a8feb531134de2974d697c

Patch Set 1 #

Messages

Total messages: 8 (4 generated)
bsheedy
+skyostil for chrome/android/javatests OWNERS Should also cover chrome/test/data.
3 years, 9 months ago (2017-03-15 21:03:39 UTC) #2
Sami
lgtm
3 years, 9 months ago (2017-03-16 11:18:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750763006/1
3 years, 9 months ago (2017-03-16 16:07:44 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 17:00:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ea7cb15bc1df999bd8a8feb53113...

Powered by Google App Engine
This is Rietveld 408576698