Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2750683002:
cc: Remove the Inputs struct from DisplayItemList (Closed)
Descriptioncc: Remove the Inputs struct from DisplayItemList
Make the members direct members of DisplayItemList instead. This was
leftover from Blimp design.
R=vmpstr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2750683002
Cr-Commit-Position: refs/heads/master@{#457458}
Committed: https://chromium.googlesource.com/chromium/src/+/829403a1084830dd160dedf24c50735e293c0bc1
Patch Set 1 #Patch Set 2 : displaylist-inputs: wtf #Patch Set 3 : displaylist-inputs: remove-inputs-again #Patch Set 4 : displaylist-inputs: reorder #Patch Set 5 : displaylist-inputs: rebaserebase #Messages
Total messages: 36 (28 generated)
Description was changed from ========== cc: Remove the Inputs struct from DisplayItemList Make the members direct members of DisplayItemList instead. This was leftover from Blimp design. R=vmpstr@chromium.org ========== to ========== cc: Remove the Inputs struct from DisplayItemList Make the members direct members of DisplayItemList instead. This was leftover from Blimp design. R=vmpstr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
overall this lgtm, but it'd be nice to figure what's going on with PS1
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
ps3 has inputs removed again, but kept identical ordering of elements
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
and ps4 reorders members of DisplayItemList again.. we'll see.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/03/15 21:39:59, danakj wrote: > and ps4 reorders members of DisplayItemList again.. we'll see. seems... good?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/03/15 22:16:00, vmpstr wrote: > On 2017/03/15 21:39:59, danakj wrote: > > and ps4 reorders members of DisplayItemList again.. we'll see. > > seems... good? yes... >_>
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Patchset #5 (id:80001) has been deleted
The CQ bit was checked by danakj@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org Link to the patchset: https://codereview.chromium.org/2750683002/#ps100001 (title: "displaylist-inputs: rebaserebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1489678410361790,
"parent_rev": "7bf3f1becca10d9c1fb493ff5d70fa5b9b2763c5", "commit_rev":
"829403a1084830dd160dedf24c50735e293c0bc1"}
Message was sent while issue was closed.
Description was changed from ========== cc: Remove the Inputs struct from DisplayItemList Make the members direct members of DisplayItemList instead. This was leftover from Blimp design. R=vmpstr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== cc: Remove the Inputs struct from DisplayItemList Make the members direct members of DisplayItemList instead. This was leftover from Blimp design. R=vmpstr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2750683002 Cr-Commit-Position: refs/heads/master@{#457458} Committed: https://chromium.googlesource.com/chromium/src/+/829403a1084830dd160dedf24c50... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as https://chromium.googlesource.com/chromium/src/+/829403a1084830dd160dedf24c50... |
