Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2750673006: [FRE] Show scroll bar if window is too small. (Closed)

Created:
3 years, 9 months ago by huangs
Modified:
3 years, 9 months ago
Reviewers:
tmartino, tommycli
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[FRE] Show scroll bar if window is too small. Previously the <body> scrollbar is hidden to prevent scrollbar glitch during initial animation. This CL enables scrollbar so it's shown when window is very small. Scrollbar glitch fix is re-implemented by wrapping the animated content (now .slide) with a fixed <div> (now .content) that has overflow-y: hidden. Also set <body> margin = 0, since otherwise <body> (height 100vh) would always have scrollbar shown. BUG=657086 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2750673006 Cr-Commit-Position: refs/heads/master@{#456867} Committed: https://chromium.googlesource.com/chromium/src/+/939b97d2936323c01181ddabe38a4e3780da242c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M chrome/browser/resources/welcome/welcome.css View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/resources/welcome/welcome.html View 1 chunk +15 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
huangs
Now addressing regular FRE, PTAL. Thanks!
3 years, 9 months ago (2017-03-14 19:59:29 UTC) #3
tmartino
lgtm
3 years, 9 months ago (2017-03-14 20:01:48 UTC) #4
tommycli
On 2017/03/14 20:01:48, tmartino wrote: > lgtm lgtm
3 years, 9 months ago (2017-03-14 20:26:37 UTC) #6
huangs
Thanks. Committing!
3 years, 9 months ago (2017-03-14 20:46:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750673006/1
3 years, 9 months ago (2017-03-14 20:46:44 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 22:36:05 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/939b97d2936323c01181ddabe38a...

Powered by Google App Engine
This is Rietveld 408576698