Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2750623004: [test] Fix mjsunit/getters-on-elements to reset function state (Closed)

Created:
3 years, 9 months ago by Leszek Swirski
Modified:
3 years, 9 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fix mjsunit/getters-on-elements to reset function state The function "foo" in "base_getter_test" was picking up a left-over optimised code object from foo's code map, the third time that base_getter_test was run, instead of optimising it itself. This broke the assumptions of the test, that each case was functionally independent from the others, and had started off with empty feedback and no optimised code. This breaks the test though, so we have to blacklist it pending a fix to the root cause (http://crbug.com/v8/6101). Review-Url: https://codereview.chromium.org/2750623004 Cr-Commit-Position: refs/heads/master@{#43828} Committed: https://chromium.googlesource.com/v8/v8/+/2b1ed9446455ba354783af288eb4d3bf510f7cc1

Patch Set 1 #

Patch Set 2 : Blacklist the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M test/mjsunit/getters-on-elements.js View 2 chunks +10 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Leszek Swirski
Hi Mike, this is the logic issue we discussed in that test. Shall we push ...
3 years, 9 months ago (2017-03-15 12:29:19 UTC) #7
mvstanton
Yep, sounds good. LGTM.
3 years, 9 months ago (2017-03-15 13:19:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750623004/20001
3 years, 9 months ago (2017-03-15 13:28:06 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 13:31:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/2b1ed9446455ba354783af288eb4d3bf510...

Powered by Google App Engine
This is Rietveld 408576698