Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2750593002: Android: Treat third_party/junit as prebuilt (Closed)

Created:
3 years, 9 months ago by Peter Wen
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Treat third_party/junit as prebuilt When we coalesce projects in Android Studio for Clank, we use the android application plugin, which does not have the java libraries needed to compile some third_party code. BUG=658024 Review-Url: https://codereview.chromium.org/2750593002 Cr-Commit-Position: refs/heads/master@{#456421} Committed: https://chromium.googlesource.com/chromium/src/+/e656a0e9c5adef78589834220eaef7de808d4471

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/junit/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Peter Wen
Hi Michael, PTAL. This was split from http://crrev.com/2724093003 as they are unrelated changes. Thanks, Peter
3 years, 9 months ago (2017-03-13 14:50:29 UTC) #2
mikecase (-- gone --)
lgtm
3 years, 9 months ago (2017-03-13 16:44:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750593002/1
3 years, 9 months ago (2017-03-13 16:58:02 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 17:53:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e656a0e9c5adef78589834220eae...

Powered by Google App Engine
This is Rietveld 408576698