Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2750553002: Add support for tracking loading behavior of child frames. (Closed)

Created:
3 years, 9 months ago by Bryan McQuade
Modified:
3 years, 9 months ago
Reviewers:
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, subresource-filter-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Add support for tracking loading behavior of child frames. This is required for the existing subresource filtering and css scanning page load metrics, as well as for the upcoming metrics for pages where media is played. In the render process: * move policy decision about whether to process timing or metadata updates from blink to chrome/renderer/page_load_metrics code * instantiate MetricsRenderFrameObservers for child frames * track metadata updates for child frames * send at most one update per second per frame over IPC to the browser process (this is the existing page load metrics IPC policy) In the browser process: * track child frame loading behavior flags * notify observers whenever the loading behavior flags for a child frame are updated In the SubresourceFilterMetricsObserver: * consider the page to have filtered subresources if subresource filter loading behavior is observed in either the main frame or child frames Note that we still do not track timing updates for child frames. This change gets us closer to being able to do so, but given that there is no current need, we don't do this for the time being. BUG=699849 NOTRY=true NOPRESUBMIT=true TBR=csharrison Review-Url: https://codereview.chromium.org/2737563007 Cr-Commit-Position: refs/heads/master@{#456166} (cherry picked from commit 2a2a964c75a71e56aa52790d2ce0bcd5a9af434a) Review-Url: https://codereview.chromium.org/2750553002 Cr-Commit-Position: refs/branch-heads/3029@{#149} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/a8cb019452819dba009c8807cd729c33337c6b92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -83 lines) Patch
M chrome/browser/page_load_metrics/metrics_web_contents_observer.cc View 2 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.h View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc View 1 chunk +38 lines, -18 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_observer.h View 3 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_observer.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_util.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_util.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_tracker.h View 3 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/page_load_metrics/page_load_tracker.cc View 4 chunks +32 lines, -14 lines 0 comments Download
M chrome/browser/subresource_filter/subresource_filter_browsertest.cc View 2 chunks +12 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M chrome/renderer/page_load_metrics/metrics_render_frame_observer.h View 3 chunks +10 lines, -2 lines 0 comments Download
M chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc View 5 chunks +17 lines, -7 lines 0 comments Download
M chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc View 2 chunks +37 lines, -3 lines 0 comments Download
M chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750553002/1
3 years, 9 months ago (2017-03-13 15:34:21 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 15:37:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a8cb019452819dba009c8807cd72...

Powered by Google App Engine
This is Rietveld 408576698