Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2750533002: [tools/perf] Re-enable browse:news:washingtonpost (keep disabled on CQ) (Closed)

Created:
3 years, 9 months ago by perezju
Modified:
3 years, 9 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Re-enable browse:news:washingtonpost (keep disabled on CQ) Enable again the benchmark to get data on perf bots, but keep disabled on CQ while flakiness is investigated. BUG=688190 Review-Url: https://codereview.chromium.org/2750533002 Cr-Commit-Position: refs/heads/master@{#456391} Committed: https://chromium.googlesource.com/chromium/src/+/6b2ad995d80a7a2b1f4ae9fde3fdade1c6319f15

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/perf/benchmarks/system_health_smoke_test.py View 1 chunk +3 lines, -0 lines 2 comments Download
M tools/perf/page_sets/system_health/browsing_stories.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
perezju
https://codereview.chromium.org/2750533002/diff/1/tools/perf/benchmarks/system_health_smoke_test.py File tools/perf/benchmarks/system_health_smoke_test.py (right): https://codereview.chromium.org/2750533002/diff/1/tools/perf/benchmarks/system_health_smoke_test.py#newcode34 tools/perf/benchmarks/system_health_smoke_test.py:34: _DISABLED_TESTS = frozenset({ side question: do we really want ...
3 years, 9 months ago (2017-03-13 12:44:07 UTC) #2
nednguyen
lgtm https://codereview.chromium.org/2750533002/diff/1/tools/perf/benchmarks/system_health_smoke_test.py File tools/perf/benchmarks/system_health_smoke_test.py (right): https://codereview.chromium.org/2750533002/diff/1/tools/perf/benchmarks/system_health_smoke_test.py#newcode34 tools/perf/benchmarks/system_health_smoke_test.py:34: _DISABLED_TESTS = frozenset({ On 2017/03/13 12:44:07, perezju wrote: ...
3 years, 9 months ago (2017-03-13 12:47:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750533002/1
3 years, 9 months ago (2017-03-13 12:54:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/381902)
3 years, 9 months ago (2017-03-13 14:15:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750533002/1
3 years, 9 months ago (2017-03-13 14:45:04 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 16:06:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6b2ad995d80a7a2b1f4ae9fde3fd...

Powered by Google App Engine
This is Rietveld 408576698