Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 275053004: Add check for bad dash interval in dash effect picture read (Closed)

Created:
6 years, 7 months ago by egdaniel
Modified:
6 years, 7 months ago
Reviewers:
caryclark, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add check for bad dash interval in dash effect picture read BUG=skia:2542 Committed: http://code.google.com/p/skia/source/detail?r=14708

Patch Set 1 #

Patch Set 2 : Remove printf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/effects/SkDashPathEffect.cpp View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
egdaniel
When reading back old Skps with SkDasPathEffect, needed to check for bad dash interval flag ...
6 years, 7 months ago (2014-05-13 13:09:27 UTC) #1
caryclark
lgtm
6 years, 7 months ago (2014-05-13 13:23:05 UTC) #2
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 7 months ago (2014-05-13 13:31:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/275053004/20001
6 years, 7 months ago (2014-05-13 13:31:42 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 14:45:30 UTC) #5
Message was sent while issue was closed. 
Change committed as 14708

Powered by Google App Engine
This is Rietveld 408576698