Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: src/effects/SkDashPathEffect.cpp

Issue 275053004: Add check for bad dash interval in dash effect picture read (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Remove printf Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/effects/SkDashPathEffect.cpp
diff --git a/src/effects/SkDashPathEffect.cpp b/src/effects/SkDashPathEffect.cpp
index 24361bd3697bbbc686f4267c149202507e9d4191..f6c7caecd94ee458eb2a0ff76bbc86bd304c0b68 100644
--- a/src/effects/SkDashPathEffect.cpp
+++ b/src/effects/SkDashPathEffect.cpp
@@ -565,10 +565,12 @@ SkDashPathEffect::SkDashPathEffect(SkReadBuffer& buffer) : INHERITED(buffer) {
if (useOldPic) {
fPhase = 0;
- for (int i = 0; i < fInitialDashIndex; ++i) {
- fPhase += fIntervals[i];
+ if (fInitialDashLength != -1) { // Signal for bad dash interval
+ for (int i = 0; i < fInitialDashIndex; ++i) {
+ fPhase += fIntervals[i];
+ }
+ fPhase += fIntervals[fInitialDashIndex] - fInitialDashLength;
}
- fPhase += fIntervals[fInitialDashIndex] - fInitialDashLength;
} else {
this->setInternalMembers(fPhase);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698