Re-land "Add support for metadata on type variables to Fasta parser." (with fixes).

Re-land "Add support for metadata on type variables to Fasta parser." (with fixes).

Last time I landed this I left a crucial `pop()` out of BodyBuilder,
resulting in test failures.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/ef79634132f8d8713e1e96c39ca540bcd864462f

[Paul Berry, 2017-03-15 16:14:51]

paulberry@google.com changed reviewers:
+ ahe@google.com, sigmund@google.com

[Paul Berry, 2017-03-15 16:14:52]

Note: patch set 1 is the CL that I landed previously (and reverted); patch set 2
includes the fixes.

https://codereview.chromium.org/2750503012/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2750503012/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:165: void
endMetadata(Token beginToken, Token periodBeforeName, Token endToken) {
Note: Konstantin introduced an implementation of this method in
08eba174cc9d5ba028f9f0d53a35f1d2190d834e, so it is no longer needed in this CL.

[Siggi Cherem (dart-lang), 2017-03-15 16:42:51]

lgtm

[Paul Berry, 2017-03-15 19:42:28]

Description was changed from

==========
Re-land "Add support for metadata on type variables to Fasta parser." (with
fixes).

Last time I landed this I left a crucial `pop()` out of BodyBuilder,
resulting in test failures.
==========

to

==========
Re-land "Add support for metadata on type variables to Fasta parser." (with
fixes).

Last time I landed this I left a crucial `pop()` out of BodyBuilder,
resulting in test failures.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ef79634132f8d8713e1e96c39ca540bcd864462f
==========

[Paul Berry, 2017-03-15 19:42:29]

Committed patchset #2 (id:20001) manually as
ef79634132f8d8713e1e96c39ca540bcd864462f (presubmit successful).

[ahe, 2017-03-16 14:32:09]

lgtm