pkg/front_end/lib/src/fasta/source/outline_builder.dart - Issue 2750503012: Re-land "Add support for metadata on type variables to Fasta parser." (with fixes).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/source/outline_builder.dart

Issue 2750503012: Re-land "Add support for metadata on type variables to Fasta parser." (with fixes). (Closed)

Patch Set: Fixes Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/front_end/lib/src/fasta/source/outline_builder.dart

diff --git a/pkg/front_end/lib/src/fasta/source/outline_builder.dart b/pkg/front_end/lib/src/fasta/source/outline_builder.dart

index 15a24a74dbcfbb88fdd7f5bd612c226187aa11cd..eeca0954d3bec9f6426a56ae8a7ccc8e51a81bb4 100644

--- a/pkg/front_end/lib/src/fasta/source/outline_builder.dart

+++ b/pkg/front_end/lib/src/fasta/source/outline_builder.dart

@@ -572,6 +572,9 @@ class OutlineBuilder extends UnhandledListener {

debugEvent("endTypeVariable");

TypeBuilder bound = pop();

String name = pop();

+ // TODO(paulberry): type variable metadata should not be ignored. See

+ // dartbug.com/28981.

+ /* List<MetadataBuilder> metadata = */ pop();

push(library.addTypeVariable(name, bound, token.charOffset));

}