Moves app_list() and related functions from Shell to WmShell

Moves app_list() and related functions from Shell to WmShell

BUG=687660
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2750483005
Cr-Commit-Position: refs/heads/master@{#456850}
Committed: https://chromium.googlesource.com/chromium/src/+/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e

[sky, 2017-03-14 19:11:35]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 19:12:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 19:55:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 19:55:18]

Dry run: This issue passed the CQ dry run.

[msw, 2017-03-14 20:20:06]

lgtm with a nit

https://codereview.chromium.org/2750483005/diff/1/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2750483005/diff/1/ash/shell.cc#newcode691
ash/shell.cc:691: app_list_.reset();
nit: probably not needed; it'd be nice to avoid implying that we need some
explicit destruction ordering/timing here (if possible).

[sky, 2017-03-14 21:06:51]

https://codereview.chromium.org/2750483005/diff/1/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2750483005/diff/1/ash/shell.cc#newcode691
ash/shell.cc:691: app_list_.reset();
On 2017/03/14 20:20:05, msw wrote:
> nit: probably not needed; it'd be nice to avoid implying that we need some
> explicit destruction ordering/timing here (if possible).

Done.

[sky, 2017-03-14 21:06:51]

The CQ bit was checked by sky@chromium.org

[sky, 2017-03-14 21:06:52]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2750483005/#ps20001
(title: "dont explicitly delete")

[commit-bot: I haz the power, 2017-03-14 21:08:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 21:52:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489525611537810,
"parent_rev": "24c87c3f418983673089663bb69045451d54f52d", "commit_rev":
"7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e"}

[commit-bot: I haz the power, 2017-03-14 21:53:16]

Description was changed from

==========
Moves app_list() and related functions from Shell to WmShell

BUG=687660
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
Moves app_list() and related functions from Shell to WmShell

BUG=687660
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2750483005
Cr-Commit-Position: refs/heads/master@{#456850}
Committed:
https://chromium.googlesource.com/chromium/src/+/7db5ccf2a7af8d8a933ed1a05890...
==========

[commit-bot: I haz the power, 2017-03-14 21:53:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7db5ccf2a7af8d8a933ed1a05890...