Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2750473004: Rebaseline writing-mode tests for Mac10.12. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
eae
CC:
blink-reviews, chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebaseline writing-mode tests for Mac10.12. TBR=eae TBR_REASON=sheriff, getting builder green again BUG=700898 Review-Url: https://codereview.chromium.org/2750473004 Cr-Commit-Position: refs/heads/master@{#456521} Committed: https://chromium.googlesource.com/chromium/src/+/98e6d4474ac2dbe5ff3305c47833c241fa937a42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -6108 lines) Patch
D third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt View 1 chunk +0 lines, -2910 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/border-vertical-lr-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/border-vertical-lr-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/japanese-lr-selection-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/japanese-lr-text-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/japanese-rl-selection-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/japanese-rl-text-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt View 1 chunk +0 lines, -2910 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/border-vertical-lr-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/border-vertical-lr-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/japanese-lr-selection-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/japanese-lr-text-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/japanese-rl-selection-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/japanese-rl-text-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt View 24 chunks +59 lines, -59 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/border-vertical-lr-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/border-vertical-lr-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/japanese-lr-selection-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/japanese-lr-text-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/japanese-rl-selection-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/japanese-rl-text-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
qyearsley
3 years, 9 months ago (2017-03-13 19:10:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750473004/1
3 years, 9 months ago (2017-03-13 22:50:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/98e6d4474ac2dbe5ff3305c47833c241fa937a42
3 years, 9 months ago (2017-03-13 22:58:14 UTC) #12
eae
3 years, 9 months ago (2017-03-14 01:29:54 UTC) #13
Message was sent while issue was closed.
LGTM
Thank you

Powered by Google App Engine
This is Rietveld 408576698