Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2750463010: [MD Bookmarks] Handle bookmark moves. (Closed)

Created:
3 years, 9 months ago by calamity
Modified:
3 years, 9 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Bookmarks] Handle bookmark moves. This CL makes MD Bookmarks responsive to bookmarks being moved. BUG=692843 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2750463010 Cr-Commit-Position: refs/heads/master@{#457700} Committed: https://chromium.googlesource.com/chromium/src/+/c867ce71a1428628b23236115c50695be40b707a

Patch Set 1 : #

Total comments: 3

Patch Set 2 : remove log #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -12 lines) Patch
M chrome/browser/resources/md_bookmarks/actions.js View 2 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/api_listener.js View 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/reducers.js View 1 3 chunks +50 lines, -9 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/reducers_test.js View 3 chunks +47 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
calamity
https://codereview.chromium.org/2750463010/diff/80001/chrome/browser/resources/md_bookmarks/api_listener.js File chrome/browser/resources/md_bookmarks/api_listener.js (right): https://codereview.chromium.org/2750463010/diff/80001/chrome/browser/resources/md_bookmarks/api_listener.js#newcode61 chrome/browser/resources/md_bookmarks/api_listener.js:61: chrome.bookmarks.onMoved.addListener(onBookmarkMoved); Sorry =(
3 years, 9 months ago (2017-03-16 06:55:07 UTC) #7
tsergeant
lgtm https://codereview.chromium.org/2750463010/diff/80001/chrome/browser/resources/md_bookmarks/api_listener.js File chrome/browser/resources/md_bookmarks/api_listener.js (right): https://codereview.chromium.org/2750463010/diff/80001/chrome/browser/resources/md_bookmarks/api_listener.js#newcode61 chrome/browser/resources/md_bookmarks/api_listener.js:61: chrome.bookmarks.onMoved.addListener(onBookmarkMoved); On 2017/03/16 06:55:07, calamity wrote: > Sorry ...
3 years, 9 months ago (2017-03-17 02:55:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750463010/100001
3 years, 9 months ago (2017-03-17 05:30:33 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 06:34:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/c867ce71a1428628b23236115c50...

Powered by Google App Engine
This is Rietveld 408576698