Reduce the number of ObjectPaintProperties

Reduce the number of ObjectPaintProperties

Now create localBorderBoxProperties for layered objects only.

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2750463003
Cr-Commit-Position: refs/heads/master@{#456904}
Committed: https://chromium.googlesource.com/chromium/src/+/ee2b1c5d8c575c1ad301471e5d1b03639da26b62

[Xianzhu, 2017-03-13 21:05:05]

Description was changed from

==========
Reduce the number of ObjectPaintProperties

BUG=700452
==========

to

==========
Reduce the number of ObjectPaintProperties

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-03-13 21:05:17]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 21:06:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 21:52:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 21:52:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-03-13 22:15:56]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2017-03-13 22:40:40]

LGTM

[Xianzhu, 2017-03-13 22:45:47]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-03-13 22:46:31]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2017-03-13 22:48:45]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-03-13 22:48:45]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2750463003/#ps40001
(title: "-")

[commit-bot: I haz the power, 2017-03-13 22:50:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-03-13 23:16:57]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2017-03-14 05:06:58]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 05:07:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 07:20:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 07:20:32]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2017-03-14 16:39:35]

Patch Set 4 fixes test failures of Patch Set 3, by using a simpler rule and
updating tests that assumed all boxes have local border box properties.

Number of localBorderBoxProperties:

     original  patch-set-3  patch-set-4
dogs:    641        133         241
nyt:    3725        291         410

The simpler rule increases number of localBorderBoxProperties, but avoids
setNeedsPaintPropertyUpdate on status changes of the conditions in Patch Set 3
(e.g. we would need setNeedsPaintPropertyUpdate when layer's self painting
status changes for Patch Set 3).

I would like to move localBorderBoxProperties out of ObjectPaintProperties,
perhaps into PaintLayer in a follow-up.

What do you think about the simpler rule and moving localBorderBoxProperties
into PaintLayer?

[pdr., 2017-03-14 16:46:03]

On 2017/03/14 at 16:39:35, wangxianzhu wrote:
> Patch Set 4 fixes test failures of Patch Set 3, by using a simpler rule and
updating tests that assumed all boxes have local border box properties.
> 
> Number of localBorderBoxProperties:
> 
>      original  patch-set-3  patch-set-4
> dogs:    641        133         241
> nyt:    3725        291         410
> 
> The simpler rule increases number of localBorderBoxProperties, but avoids
setNeedsPaintPropertyUpdate on status changes of the conditions in Patch Set 3
(e.g. we would need setNeedsPaintPropertyUpdate when layer's self painting
status changes for Patch Set 3).
> 
> I would like to move localBorderBoxProperties out of ObjectPaintProperties,
perhaps into PaintLayer in a follow-up.
> 
> What do you think about the simpler rule and moving localBorderBoxProperties
into PaintLayer?

I like simple! Lgtm

[Xianzhu, 2017-03-14 21:55:47]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-03-14 21:55:47]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2750463003/#ps80001
(title: "")

[commit-bot: I haz the power, 2017-03-14 21:56:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-03-14 23:58:59]

Description was changed from

==========
Reduce the number of ObjectPaintProperties

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Reduce the number of ObjectPaintProperties

Now create localBorderBoxProperties for layered objects only.

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2017-03-15 00:08:06]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489528547111570,
"parent_rev": "9c8aefe72593bb63ccc20dd34fae9ea034b3d709", "commit_rev":
"ee2b1c5d8c575c1ad301471e5d1b03639da26b62"}

[commit-bot: I haz the power, 2017-03-15 00:09:39]

Description was changed from

==========
Reduce the number of ObjectPaintProperties

Now create localBorderBoxProperties for layered objects only.

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Reduce the number of ObjectPaintProperties

Now create localBorderBoxProperties for layered objects only.

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2750463003
Cr-Commit-Position: refs/heads/master@{#456904}
Committed:
https://chromium.googlesource.com/chromium/src/+/ee2b1c5d8c575c1ad301471e5d1b...
==========

[commit-bot: I haz the power, 2017-03-15 00:09:40]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/ee2b1c5d8c575c1ad301471e5d1b...