Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2750463003: Reduce the number of ObjectPaintProperties (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce the number of ObjectPaintProperties Now create localBorderBoxProperties for layered objects only. BUG=700452 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2750463003 Cr-Commit-Position: refs/heads/master@{#456904} Committed: https://chromium.googlesource.com/chromium/src/+/ee2b1c5d8c575c1ad301471e5d1b03639da26b62

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : - #

Patch Set 4 : x #

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -56 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 1 2 3 6 chunks +46 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (20 generated)
Xianzhu
3 years, 9 months ago (2017-03-13 22:15:57 UTC) #7
pdr.
LGTM
3 years, 9 months ago (2017-03-13 22:40:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750463003/40001
3 years, 9 months ago (2017-03-13 22:50:09 UTC) #13
Xianzhu
Patch Set 4 fixes test failures of Patch Set 3, by using a simpler rule ...
3 years, 9 months ago (2017-03-14 16:39:35 UTC) #19
pdr.
On 2017/03/14 at 16:39:35, wangxianzhu wrote: > Patch Set 4 fixes test failures of Patch ...
3 years, 9 months ago (2017-03-14 16:46:03 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750463003/80001
3 years, 9 months ago (2017-03-14 21:56:35 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 00:09:40 UTC) #27
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/ee2b1c5d8c575c1ad301471e5d1b...

Powered by Google App Engine
This is Rietveld 408576698