Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Issue 2750433002: Do not treat substitute-data resources as having successful HTTP status codes. (Closed)

Created:
3 years, 9 months ago by Mike West
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Do not treat substitute-data resources as having successful HTTP status codes. Some embedders of Blink (Chrome in particular) rely on error pages having an HTTP status code of `0`. [1] changed this behavior to synthesize a 200 status code. This patch changes that behavior back to the original expectation, matching the expectation that non-network requests don't have network status information. [1]: https://chromium.googlesource.com/chromium/blink/+/63b8349e922a3691bb77f74d7b2f143a5f023626 BUG=656845 Review-Url: https://codereview.chromium.org/2676443004 Cr-Commit-Position: refs/heads/master@{#455810} (cherry picked from commit 1709b0599a7329585a3d781b21b1cbbb15379d7c) Review-Url: https://codereview.chromium.org/2750433002 . Cr-Commit-Position: refs/branch-heads/3029@{#141} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/786e9d4707ec38cdb51eef38f6c635028e94b046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Mike West
3 years, 9 months ago (2017-03-13 07:51:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
786e9d4707ec38cdb51eef38f6c635028e94b046 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698