test.py: Push dart_precompiled_runtime and process_test once per device instead of once per test.

test.py: Push dart_precompiled_runtime and process_test once per device instead of once per test.

R=kustermann@google.com, vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/25282fbf641ad8f94b609bf4eaab38b5dc46695f

[rmacnak, 2017-03-17 22:58:13]

rmacnak@google.com changed reviewers:
+ kustermann@google.com, vegorov@google.com

[rmacnak, 2017-03-17 22:58:14]

With a Nexus 9 and two Nexus 4's, I see the following speed up.

./tools/test.py --system=android -mrelease -aarm language/first -cprecompiler
-rdart_precompiled --use-blobs
Test configuration: precompiler_dart_precompiled_release_arm
[01:34 | 100% | +   18 | -    0]

./tools/test.py --system=android -mrelease -aarm language/first -cprecompiler
-rdart_precompiled --use-blobs
Test configuration: precompiler_dart_precompiled_release_arm
Found 3 Android devices.
[00:25 | 100% | +   18 | -    0]

[Vyacheslav Egorov (Google), 2017-03-19 08:26:31]

lgtm

[kustermann, 2017-03-19 17:11:05]

https://codereview.chromium.org/2750403006/diff/1/tools/testing/dart/android....
File tools/testing/dart/android.dart (right):

https://codereview.chromium.org/2750403006/diff/1/tools/testing/dart/android....
tools/testing/dart/android.dart:260: return _adbCommand(['push', local,
remote]);
This is not quite safe I think: It's possible to run test.py in a way which runs
multiple configurations at the same time, for example:

./tools/test.py -mdebug,release -cprecompiler -rdart_precompiled 

This will run release and debug in one go. It will queue up the commands
randomly, so we can end up in a situation where we run these two commands

pushCachedData('out/ReleaseXARM/file', '/data/local/temp/file')
pushCachedData('out/DebugXARM/file', '/data/local/temp/file')

The first will push the binary, the second would reuse the binary (which is not
safe).

If you just use a Map<Remote, Local> then you can check if the Remote is
up-to-date and do nothing and otherwise push a new local.

[rmacnak, 2017-03-20 21:04:23]

On 2017/03/19 17:11:05, kustermann wrote:
>
https://codereview.chromium.org/2750403006/diff/1/tools/testing/dart/android....
> File tools/testing/dart/android.dart (right):
> 
>
https://codereview.chromium.org/2750403006/diff/1/tools/testing/dart/android....
> tools/testing/dart/android.dart:260: return _adbCommand(['push', local,
> remote]);
> This is not quite safe I think: It's possible to run test.py in a way which
runs
> multiple configurations at the same time, for example:
> 
> ./tools/test.py -mdebug,release -cprecompiler -rdart_precompiled 
> 
> This will run release and debug in one go. It will queue up the commands
> randomly, so we can end up in a situation where we run these two commands
> 
> pushCachedData('out/ReleaseXARM/file', '/data/local/temp/file')
> pushCachedData('out/DebugXARM/file', '/data/local/temp/file')
> 
> The first will push the binary, the second would reuse the binary (which is
not
> safe).
> 
> If you just use a Map<Remote, Local> then you can check if the Remote is
> up-to-date and do nothing and otherwise push a new local.

Good catch! Verified it does break when running multiple configs. Updated to a
map as you suggest and that does fix it.

[kustermann, 2017-03-21 12:10:16]

LGTM

[rmacnak, 2017-03-21 16:45:40]

Description was changed from

==========
test.py: Push dart_precompiled_runtime and process_test once per device instead
of once per test.
==========

to

==========
test.py: Push dart_precompiled_runtime and process_test once per device instead
of once per test.

R=kustermann@google.com, vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/25282fbf641ad8f94b609bf4eaab38b5dc46695f
==========

[rmacnak, 2017-03-21 16:45:41]

Committed patchset #2 (id:20001) manually as
25282fbf641ad8f94b609bf4eaab38b5dc46695f (presubmit successful).

[rmacnak, 2017-03-21 19:10:33]

On 2017/03/21 16:45:41, rmacnak wrote:
> Committed patchset #2 (id:20001) manually as
> 25282fbf641ad8f94b609bf4eaab38b5dc46695f (presubmit successful).

vm-precomp-android-release-1-3-be went from 124:01 to 26:36.