Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 2750403006: test.py: Push dart_precompiled_runtime and process_test once per device instead of once per test. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/android.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 292416e6d62d5fc1d2e598b7ec836bbfbf2877a8..da29ce5b8424eb0b0418d68ff4c319fcfd7ef097 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -2734,13 +2734,10 @@ class CommandExecutorImpl implements CommandExecutor {
steps.add(() => device.runAdbShellCommand(['rm', '-Rf', deviceTestDir]));
steps.add(() => device.runAdbShellCommand(['mkdir', '-p', deviceTestDir]));
- // TODO: We should find a way for us to cache the runner binary and avoid
- // pushhing it for every single test (this is bad for SSD cycle time, test
- // timing).
- steps.add(() => device.runAdbCommand(
- ['push', runner, '$devicedir/dart_precompiled_runtime']));
- steps.add(() => device.runAdbCommand(
- ['push', processTest, '$devicedir/process_test']));
+ steps.add(() => device.pushCachedData(runner,
+ '$devicedir/dart_precompiled_runtime'));
+ steps.add(() => device.pushCachedData(processTest,
+ '$devicedir/process_test'));
steps.add(() => device.runAdbShellCommand(
['chmod', '777', '$devicedir/dart_precompiled_runtime $devicedir/process_test']));
« no previous file with comments | « tools/testing/dart/android.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698