Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2750403004: [intl] Fix debug-evaluate-no-side-effect-builtins test (Closed)

Created:
3 years, 9 months ago by Dan Ehrenberg
Modified:
3 years, 9 months ago
Reviewers:
adamk, Yang
CC:
v8-reviews_googlegroups.com, Michael Achenbach, jwolfe, jungshik at Google
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[intl] Fix debug-evaluate-no-side-effect-builtins test String case conversion is known to debug-evaluate to not have a side effect in noi18n mode, but debug-evaluate thinks it has a side effect in i18n mode. Update the tests accordingly. Verified locally that the test passes in i18n and noi18n mode (not sure whether the noi18n trybot executes this test). CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng Review-Url: https://codereview.chromium.org/2750403004 Cr-Commit-Position: refs/heads/master@{#43882} Committed: https://chromium.googlesource.com/v8/v8/+/3fa263384148e93a9238642df8c0834811fbbc8d

Patch Set 1 #

Patch Set 2 : Fix test more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M test/debugger/debug/debug-evaluate-no-side-effect-builtins.js View 1 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Dan Ehrenberg
3 years, 9 months ago (2017-03-16 22:26:47 UTC) #7
adamk
lgtm
3 years, 9 months ago (2017-03-16 22:29:36 UTC) #8
Yang
On 2017/03/16 22:29:36, adamk wrote: > lgtm lgtm. thanks.
3 years, 9 months ago (2017-03-17 06:20:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750403004/20001
3 years, 9 months ago (2017-03-17 07:16:29 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 07:18:15 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/3fa263384148e93a9238642df8c0834811f...

Powered by Google App Engine
This is Rietveld 408576698