Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2750393002: [NTP Snippets] Don't attempt to fetch remote suggestions without API key (Closed)

Created:
3 years, 9 months ago by Marc Treib
Modified:
3 years, 9 months ago
Reviewers:
Bernhard Bauer, gambard
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, ntp-dev+reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, asvitkine+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Don't attempt to fetch remote suggestions without API key The API to fetch remote content suggestions is private; it won't work without the official Google Chrome API keys. If they're not available, don't even attempt to fetch. TBRing a new enum entry in histograms.xml TBR=asvitkine BUG=702189 Review-Url: https://codereview.chromium.org/2750393002 Cr-Commit-Position: refs/heads/master@{#457721} Committed: https://chromium.googlesource.com/chromium/src/+/f36a84d6ee362acb8803b7004f3f22b2130c7dca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -15 lines) Patch
M chrome/browser/ntp_snippets/content_suggestions_service_factory.cc View 2 chunks +12 lines, -8 lines 0 comments Download
M components/ntp_snippets/remote/json_request.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_fetcher.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_fetcher_unittest.cc View 3 chunks +22 lines, -2 lines 0 comments Download
M ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Marc Treib
PTAL!
3 years, 9 months ago (2017-03-16 17:12:25 UTC) #6
Bernhard Bauer
LGTM!
3 years, 9 months ago (2017-03-16 17:31:18 UTC) #7
Marc Treib
+gambard for ios, PTAL!
3 years, 9 months ago (2017-03-16 17:36:33 UTC) #10
gambard
ios/ lgtm
3 years, 9 months ago (2017-03-17 07:44:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750393002/1
3 years, 9 months ago (2017-03-17 09:00:59 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 09:06:09 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f36a84d6ee362acb8803b7004f3f...

Powered by Google App Engine
This is Rietveld 408576698