[Payment Request] supported card networks + adding a credit card.

[Payment Request] supported card networks + adding a credit card.

Exposes the supported card networks in PaymentRequest. Also adds a
function to add a credit card to the list of cached credit cards.

BUG=602666
Review-Url: https://codereview.chromium.org/2750363002
Cr-Commit-Position: refs/heads/master@{#457479}
Committed: https://chromium.googlesource.com/chromium/src/+/e9f8e8781db383152e4243e459795d4f6e04d547

[Moe, 2017-03-16 13:50:31]

mahmadi@chromium.org changed reviewers:
+ rouslan@chromium.org

[Moe, 2017-03-16 13:50:32]

Hi Rouslan, Please take a look.

[please use gerrit instead, 2017-03-16 14:36:41]

https://codereview.chromium.org/2750363002/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/payment_request.h (right):

https://codereview.chromium.org/2750363002/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_request.h:97: const
std::vector<std::string>& supported_card_networks() {
This method should be "const".

https://codereview.chromium.org/2750363002/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/payment_request.mm (right):

https://codereview.chromium.org/2750363002/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_request.mm:82:
supported_card_networks_.push_back(base::UTF16ToASCII(supported_method));
Reject non-ASCII supported_methods.

[Moe, 2017-03-16 15:59:46]

PTAL

https://codereview.chromium.org/2750363002/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/payment_request.h (right):

https://codereview.chromium.org/2750363002/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_request.h:97: const
std::vector<std::string>& supported_card_networks() {
On 2017/03/16 14:36:40, ಠ_ಠ wrote:
> This method should be "const".

Done.

https://codereview.chromium.org/2750363002/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/payment_request.mm (right):

https://codereview.chromium.org/2750363002/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_request.mm:82:
supported_card_networks_.push_back(base::UTF16ToASCII(supported_method));
On 2017/03/16 14:36:40, ಠ_ಠ wrote:
> Reject non-ASCII supported_methods.

Done.

[please use gerrit instead, 2017-03-16 17:21:03]

lgtm

[Moe, 2017-03-16 17:26:43]

On 2017/03/16 17:21:03, ಠ_ಠ wrote:
> lgtm

Thank you.

[Moe, 2017-03-16 17:26:48]

The CQ bit was checked by mahmadi@chromium.org

[commit-bot: I haz the power, 2017-03-16 17:27:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 17:40:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489685208389980,
"parent_rev": "74a8e1b5da717c00e190aabc58c29b54430985c6", "commit_rev":
"e9f8e8781db383152e4243e459795d4f6e04d547"}

[commit-bot: I haz the power, 2017-03-16 17:41:17]

Description was changed from

==========
[Payment Request] supported card networks + adding a credit card.

Exposes the supported card networks in PaymentRequest. Also adds a
function to add a credit card to the list of cached credit cards.

BUG=602666
==========

to

==========
[Payment Request] supported card networks + adding a credit card.

Exposes the supported card networks in PaymentRequest. Also adds a
function to add a credit card to the list of cached credit cards.

BUG=602666

Review-Url: https://codereview.chromium.org/2750363002
Cr-Commit-Position: refs/heads/master@{#457479}
Committed:
https://chromium.googlesource.com/chromium/src/+/e9f8e8781db383152e4243e45979...
==========

[commit-bot: I haz the power, 2017-03-16 17:41:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e9f8e8781db383152e4243e45979...