Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2750363002: [Payment Request] supported card networks + adding a credit card. (Closed)

Created:
3 years, 9 months ago by Moe
Modified:
3 years, 9 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, mahmadi+paymentsioswatch_chromium.org, pkl (ping after 24h if needed), gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, mahmadi+paymentswatch_chromium.org, sebsg+paymentswatch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] supported card networks + adding a credit card. Exposes the supported card networks in PaymentRequest. Also adds a function to add a credit card to the list of cached credit cards. BUG=602666 Review-Url: https://codereview.chromium.org/2750363002 Cr-Commit-Position: refs/heads/master@{#457479} Committed: https://chromium.googlesource.com/chromium/src/+/e9f8e8781db383152e4243e459795d4f6e04d547

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -31 lines) Patch
M ios/chrome/browser/payments/payment_request.h View 1 2 chunks +10 lines, -0 lines 0 comments Download
M ios/chrome/browser/payments/payment_request.mm View 1 4 chunks +17 lines, -7 lines 0 comments Download
M ios/chrome/browser/payments/payment_request_unittest.mm View 2 chunks +60 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Moe
Hi Rouslan, Please take a look.
3 years, 9 months ago (2017-03-16 13:50:32 UTC) #2
please use gerrit instead
https://codereview.chromium.org/2750363002/diff/1/ios/chrome/browser/payments/payment_request.h File ios/chrome/browser/payments/payment_request.h (right): https://codereview.chromium.org/2750363002/diff/1/ios/chrome/browser/payments/payment_request.h#newcode97 ios/chrome/browser/payments/payment_request.h:97: const std::vector<std::string>& supported_card_networks() { This method should be "const". ...
3 years, 9 months ago (2017-03-16 14:36:41 UTC) #3
Moe
PTAL https://codereview.chromium.org/2750363002/diff/1/ios/chrome/browser/payments/payment_request.h File ios/chrome/browser/payments/payment_request.h (right): https://codereview.chromium.org/2750363002/diff/1/ios/chrome/browser/payments/payment_request.h#newcode97 ios/chrome/browser/payments/payment_request.h:97: const std::vector<std::string>& supported_card_networks() { On 2017/03/16 14:36:40, ಠ_ಠ ...
3 years, 9 months ago (2017-03-16 15:59:46 UTC) #4
please use gerrit instead
lgtm
3 years, 9 months ago (2017-03-16 17:21:03 UTC) #5
Moe
On 2017/03/16 17:21:03, ಠ_ಠ wrote: > lgtm Thank you.
3 years, 9 months ago (2017-03-16 17:26:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750363002/20001
3 years, 9 months ago (2017-03-16 17:27:54 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 17:41:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e9f8e8781db383152e4243e45979...

Powered by Google App Engine
This is Rietveld 408576698