[Android] Histogram for Android restore

[Android] Histogram for Android restore

During restore save the result of the restore (success, or failure with
reason) in a SharedPreference. The first time Chrome is run copy this
value to a UMA histogram, or record that no restore happened.

BUG=685774
Review-Url: https://codereview.chromium.org/2750323002
Cr-Commit-Position: refs/heads/master@{#457755}
Committed: https://chromium.googlesource.com/chromium/src/+/505818ae0cb3074323a9f840d0edcfcd50004ded

[aberent, 2017-03-16 11:25:32]

aberent@chromium.org changed reviewers:
+ bauerb@chromium.org, rkaplow@chromium.org

[aberent, 2017-03-16 11:25:32]

bauerb@: Please review.
rkaplow: Please review, as OWNER, the new histogram added to histograms.xml

[aberent, 2017-03-16 11:26:00]

The CQ bit was checked by aberent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 11:26:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2017-03-16 11:36:37]

LGTM w/ nits:

https://codereview.chromium.org/2750323002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java
(right):

https://codereview.chromium.org/2750323002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java:51: *
:)

https://codereview.chromium.org/2750323002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java:60:
// Restore status is used to pass the result of any restore to Chrome's first
run, so that
Can you leave empty lines before comments?

https://codereview.chromium.org/2750323002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java:78:
private static final String RESTORE_STATUS = "Android_restore_status";
Nit: The combination of uppercase initial and underscores looks a bit weird :)
Lowercase everything?

https://codereview.chromium.org/2750323002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java:399:
* Set the restore status
Nit: I don't think this comments adds any value.

https://codereview.chromium.org/2750323002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2750323002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:80760: +  <int value="4" label="Failed:
Cannot sign in as former user"/>
Nit: "previous user" maybe? "Former user" sounds a bit like the ex-parrot ;-)

[aberent, 2017-03-16 12:16:23]

The CQ bit was checked by aberent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 12:16:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aberent, 2017-03-16 12:16:51]

https://codereview.chromium.org/2750323002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java
(right):

https://codereview.chromium.org/2750323002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java:51: *
On 2017/03/16 11:36:36, Bernhard Bauer wrote:
> :)

Done.

https://codereview.chromium.org/2750323002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java:60:
// Restore status is used to pass the result of any restore to Chrome's first
run, so that
On 2017/03/16 11:36:36, Bernhard Bauer wrote:
> Can you leave empty lines before comments?

Done here, and where I think it helps readability elsewhere in the file (most
but not every case).

Note, however, that git cl format is taking out blank lines at the start of
methods, so I can't do this everywhere.

https://codereview.chromium.org/2750323002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java:78:
private static final String RESTORE_STATUS = "Android_restore_status";
On 2017/03/16 11:36:36, Bernhard Bauer wrote:
> Nit: The combination of uppercase initial and underscores looks a bit weird :)
> Lowercase everything?

Done.

https://codereview.chromium.org/2750323002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java:399:
* Set the restore status
On 2017/03/16 11:36:36, Bernhard Bauer wrote:
> Nit: I don't think this comments adds any value.

Updated comment.

https://codereview.chromium.org/2750323002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2750323002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:80760: +  <int value="4" label="Failed:
Cannot sign in as former user"/>
On 2017/03/16 11:36:36, Bernhard Bauer wrote:
> Nit: "previous user" maybe? "Former user" sounds a bit like the ex-parrot ;-)

Done.

[commit-bot: I haz the power, 2017-03-16 13:06:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 13:06:12]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-03-16 14:34:01]

https://codereview.chromium.org/2750323002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java
(right):

https://codereview.chromium.org/2750323002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java:60:
// Restore status is used to pass the result of any restore to Chrome's first
run, so that
On 2017/03/16 12:16:50, aberent wrote:
> On 2017/03/16 11:36:36, Bernhard Bauer wrote:
> > Can you leave empty lines before comments?
> 
> Done here, and where I think it helps readability elsewhere in the file (most
> but not every case).
> 
> Note, however, that git cl format is taking out blank lines at the start of
> methods, so I can't do this everywhere.

That's fine, I wouldn't add them there either (or at the beginning of a block in
general).

[rkaplow, 2017-03-16 19:01:57]

lgtm

[Bernhard Bauer, 2017-03-17 12:15:18]

The CQ bit was checked by bauerb@chromium.org

[Bernhard Bauer, 2017-03-17 12:15:18]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2750323002/#ps20001
(title: "fix bauerb@s nits")

[commit-bot: I haz the power, 2017-03-17 12:15:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 13:59:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489752918376470,
"parent_rev": "f4ae1808d7df0ae6d41ee04511cb289b5faa6d25", "commit_rev":
"505818ae0cb3074323a9f840d0edcfcd50004ded"}

[commit-bot: I haz the power, 2017-03-17 14:00:37]

Description was changed from

==========
[Android] Histogram for Android restore

During restore save the result of the restore (success, or failure with
reason) in a SharedPreference. The first time Chrome is run copy this
value to a UMA histogram, or record that no restore happened.

BUG=685774
==========

to

==========
[Android] Histogram for Android restore

During restore save the result of the restore (success, or failure with
reason) in a SharedPreference. The first time Chrome is run copy this
value to a UMA histogram, or record that no restore happened.

BUG=685774

Review-Url: https://codereview.chromium.org/2750323002
Cr-Commit-Position: refs/heads/master@{#457755}
Committed:
https://chromium.googlesource.com/chromium/src/+/505818ae0cb3074323a9f840d0ed...
==========

[commit-bot: I haz the power, 2017-03-17 14:00:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/505818ae0cb3074323a9f840d0ed...