DescriptionRevert of [Dashboard] Start using /list_tests's test_path_dict mode in test-picker (patchset #12 id:220001 of https://codereview.chromium.org/2716683004/ )
Reason for revert:
Broke restoring reports from page_state. Fix in progress.
Original issue's description:
> [Dashboard] Start using /list_tests's test_path_dict mode in test-picker
>
> As of this CL, it should be immediately possible to factor away test-picker's
> request for the subtest dict in favor of an approach that uses the new endpoint.
> The functionality in this CL subsumes report-page's need for the functionality
> of test-picker that depended on the subtest dict, and now it is only test-picker
> itself that uses the subtest dict (to populate its menus).
>
> In parallel, this CL offers up a couple more avenues for interesting work:
> 1. Request parallelization. We will need to clean up simple_xhr probably in
> favor of fetch (see
> https://github.com/catapult-project/catapult/issues/3389).
> 2. group_report ref build fix. To surface ref builds correctly in group_report,
> we need to modify the endpoint to be able to look at siblings in addition to
> children, and we need to get rid of addSeriesGroup.
>
> In addition to the picker speedup, two necessary pieces that were not done in
> this CL, but should be done immediately as followups, are:
>
> 1. Deleting addSeriesGroup. See
> https://github.com/catapult-project/catapult/issues/3385.
> 2. Better error handling in the picker, see
> https://github.com/catapult-project/catapult/issues/3390.
> 3. Deleting testselection. It's basically dead code but there's one helper
> still used by chart-container that may or may not be necessary.
>
> Demo: https://dev-eakuefner-d97f1223-dot-chromeperf.appspot.com/report
>
> BUG=catapult:#3228
>
> Review-Url: https://codereview.chromium.org/2716683004
> Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9fff60268747d20514d711257117c53e5c1f0b7c
TBR=simonhatch@chromium.org,sullivan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=catapult:#3228
Review-Url: https://codereview.chromium.org/2750313003
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/1a27e1a497217d6d628a2c035d1b3b9369f16f64
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|