Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2750313003: Revert of [Dashboard] Start using /list_tests's test_path_dict mode in test-picker (Closed)

Created:
3 years, 9 months ago by eakuefner
Modified:
3 years, 9 months ago
Reviewers:
sullivan, shatch
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Dashboard] Start using /list_tests's test_path_dict mode in test-picker (patchset #12 id:220001 of https://codereview.chromium.org/2716683004/ ) Reason for revert: Broke restoring reports from page_state. Fix in progress. Original issue's description: > [Dashboard] Start using /list_tests's test_path_dict mode in test-picker > > As of this CL, it should be immediately possible to factor away test-picker's > request for the subtest dict in favor of an approach that uses the new endpoint. > The functionality in this CL subsumes report-page's need for the functionality > of test-picker that depended on the subtest dict, and now it is only test-picker > itself that uses the subtest dict (to populate its menus). > > In parallel, this CL offers up a couple more avenues for interesting work: > 1. Request parallelization. We will need to clean up simple_xhr probably in > favor of fetch (see > https://github.com/catapult-project/catapult/issues/3389). > 2. group_report ref build fix. To surface ref builds correctly in group_report, > we need to modify the endpoint to be able to look at siblings in addition to > children, and we need to get rid of addSeriesGroup. > > In addition to the picker speedup, two necessary pieces that were not done in > this CL, but should be done immediately as followups, are: > > 1. Deleting addSeriesGroup. See > https://github.com/catapult-project/catapult/issues/3385. > 2. Better error handling in the picker, see > https://github.com/catapult-project/catapult/issues/3390. > 3. Deleting testselection. It's basically dead code but there's one helper > still used by chart-container that may or may not be necessary. > > Demo: https://dev-eakuefner-d97f1223-dot-chromeperf.appspot.com/report > > BUG=catapult:#3228 > > Review-Url: https://codereview.chromium.org/2716683004 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9fff60268747d20514d711257117c53e5c1f0b7c TBR=simonhatch@chromium.org,sullivan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=catapult:#3228 Review-Url: https://codereview.chromium.org/2750313003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/1a27e1a497217d6d628a2c035d1b3b9369f16f64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -263 lines) Patch
M dashboard/dashboard/elements/chart-container.html View 6 chunks +8 lines, -72 lines 0 comments Download
M dashboard/dashboard/elements/report-page.html View 4 chunks +7 lines, -76 lines 0 comments Download
M dashboard/dashboard/elements/test-picker.html View 4 chunks +68 lines, -88 lines 0 comments Download
M dashboard/dashboard/elements/test-picker-test.html View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
eakuefner
Created Revert of [Dashboard] Start using /list_tests's test_path_dict mode in test-picker
3 years, 9 months ago (2017-03-16 19:03:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750313003/1
3 years, 9 months ago (2017-03-16 19:03:56 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 19:04:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698